Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor syntax error in the streaming doc #673

Closed
aykutkardas opened this issue May 12, 2024 · 2 comments
Closed

Docs: Minor syntax error in the streaming doc #673

aykutkardas opened this issue May 12, 2024 · 2 comments

Comments

@aykutkardas
Copy link

What is the update you wish to see?

I noticed minor thing in the document.

Expected:

const revenue = await fetchRevenue() // delete this line
image

Is there any context that might help us understand?

no

Does the docs page already exist? Please link to it.

https://nextjs.org/learn/dashboard-app/streaming#streaming-a-component

@GaneshSrambikal
Copy link

GaneshSrambikal commented May 30, 2024

Hello,
What you want to point out is that in line 8:
const revenue = await fetchRevenue // delete this line

Which should be

const revenue = await fetchRevenue() // delete this line

In my opinion, although we are removing the const revenue = await fetchRevenue() from /app/dashboard/(overview)/page.tsx

and fetching it in /app/ui/dashboard/revenue-chart.tsx ,

next_issue_673

Agreeing that this is a minor syntax error but understandable as we are removing it from the code.

Thank You.

@leerob
Copy link
Member

leerob commented Jun 23, 2024

Fixed! Thank you.

@leerob leerob closed this as completed Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants