Skip to content

Commit

Permalink
Enable esmExternals by default (#29878)
Browse files Browse the repository at this point in the history
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
  • Loading branch information
timneutkens committed Oct 13, 2021
1 parent d1d7a95 commit d622534
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 124 deletions.
2 changes: 1 addition & 1 deletion packages/next/server/config-shared.ts
Expand Up @@ -218,7 +218,7 @@ export const defaultConfig: NextConfig = {
disableOptimizedLoading: false,
gzipSize: true,
craCompat: false,
esmExternals: false,
esmExternals: true,
staticPageGenerationTimeout: 60,
// default to 50MB limit
isrMemoryCacheSize: 50 * 1024 * 1024,
Expand Down
10 changes: 0 additions & 10 deletions test/integration/externals/next.config.js

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions test/integration/externals/node_modules/esm-package/wrong.mjs

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion test/integration/externals/node_modules/preact/compat.js

This file was deleted.

17 changes: 0 additions & 17 deletions test/integration/externals/pages/ssg.js

This file was deleted.

15 changes: 0 additions & 15 deletions test/integration/externals/pages/ssr.js

This file was deleted.

11 changes: 0 additions & 11 deletions test/integration/externals/pages/static.js

This file was deleted.

42 changes: 0 additions & 42 deletions test/integration/externals/test/index.test.js

This file was deleted.

0 comments on commit d622534

Please sign in to comment.