Enable esmExternals by default

[timneutkens]

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes

[ijjk]

Failing test suites

Commit: 0a2f477

test/integration/externals/test/index.test.js

• Handle ESM externals > should render the static page
• Handle ESM externals > should render the ssr page
• Handle ESM externals > should render the ssg page

Expand output

● Handle ESM externals › should render the static page

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Handle ESM externals › should render the ssr page

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Handle ESM externals › should render the ssg page

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  329 | export async function killApp(instance) {
  330 |   await new Promise((resolve, reject) => {
> 331 |     treeKill(instance.pid, (err) => {
      |                       ^
  332 |       if (err) {
  333 |         if (
  334 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:331:23
  at Object.killApp (lib/next-test-utils.js:330:9)
  at integration/externals/test/index.test.js:11:25

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
buildDuration	12.2s	11.9s	-340ms
buildDurationCached	2.7s	2.8s	⚠️ +139ms
nodeModulesSize	200 MB	200 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.643	2.622	-0.02
/ avg req/sec	946	953.42	+7.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.175	1.299	⚠️ +0.12
/error-in-render avg req/sec	2127.07	1925.07	⚠️ -202

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
_buildManifest.js gzip	493 B	493 B	✓
Overall change	493 B	493 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
index.html gzip	540 B	540 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
buildDuration	6s	6s	⚠️ +37ms
buildDurationCached	2.9s	2.8s	-82ms
nodeModulesSize	200 MB	200 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.622	2.547	-0.07
/ avg req/sec	953.4	981.44	+28.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.243	1.255	⚠️ +0.01
/error-in-render avg req/sec	2011.6	1991.26	⚠️ -20.34

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	35 kB	35 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	355 B	355 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	555 B	555 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.22 kB	2.22 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
_buildManifest.js gzip	512 B	512 B	✓
Overall change	512 B	512 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/enable-esmexternals	Change
index.html gzip	538 B	538 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	532 B	532 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: ea9e923