CSS concatenation order matches the import order #39889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAlbin
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
Given the amount of CSS ordering problems mentioned in the issue queue (see vercel#16630), it's clear, for most people, that it is NOT obvious that the order of CSS concatenation matches the order of importing CSS and modules. We should try to make this fact explicit in the docs. Right now, it's only implied.
ijjk
force-pushed
the
canary
branch
3 times, most recently
from
df8579c
to
47e5ebe
Compare
ijjk
force-pushed
the
canary
branch
2 times, most recently
from
e078ebe
to
6b863fe
Compare
# Conflicts: # docs/basic-features/built-in-css-support.md
ijjk
approved these changes
Jun 14, 2023
|
What about on the root |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the amount of CSS ordering problems mentioned in the issue queue (see #16630), it's clear, for most people, that it is NOT obvious that the order of CSS concatenation matches the order of importing CSS and modules inside
_app.js.We should try to make this fact explicit in the docs. Right now, it's only implied.
Documentation checklist
pnpm lint