Double RSC fetch after server action redirect #66166
Labels
bug
Issue was opened via the bug report template.
locked
Navigation
Related to Next.js linking (e.g., <Link>) and navigation.
Comments
github-actions
bot
added
the
Navigation
|
This has been reported here as well: Since the _rsc request is discarded, in light of a redirect, the tests setup in test/e2e/app-dir/navigation/navigation.test.ts pass, but the issue is there too. For example, say, you have this route handler: // test/e2e/app-dir/navigation/app/redirect/result/api/route.js
let t = 0
const getTime = () => t++
export const GET = (req) => {
const rsc = req.nextUrl.searchParams.get('_rsc')
return new Response(
`<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Document</title>
</head>
<body>
<h1 id="result-page">Result Page</h1>
<div id="counter">${getTime()}</div>
<div id="rsc">${rsc || 'no-rsc'}</div>
</body>
</html>
`,
{ status: 200, statusText: 'OK', headers: { 'Content-Type': 'text/html' } }
)
}Then you can write a test: // test/e2e/app-dir/navigation/navigation.test.ts around line 500-ish
it('should only trigger the redirect once for Route Handlers', async () => {
const path = '/redirect/redirect-with-loading/to-api'
const browser = await next.browser(path)
const counter = await browser.waitForElementByCss('#counter').text()
expect(counter).toBe('0')
})And that'll error out because counter will be actually 1. I haven't had time to deep dive into why the _rsc request is made though |
|
Fixed #66620 |
|
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Link to the code that reproduces this issue
https://github.com/cfrank/next.js
To Reproduce
pnpm ipnpm buildNEXT_TEST_SKIP_CLEANUP=1 pnpm test-start test/e2e/app-dir/actions/app-action.test.ts/tmp/next-install-*)pnpm nextCurrent vs. Expected behavior
Currently when performing a redirect within a server action we are correctly resolving the RSC bundle within the
POSTrequest and performing the client side redirect to the destination path. But upon loading the destination path we are performing a subsequent fetch of the destination path:Provide environment information
Which area(s) are affected? (Select all that apply)
Navigation
Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local), Other (Deployed)
Additional context
I encountered this bug while working on #64604 where I added more robust tests to verify that only a single request was being made during server action redirects. When I opened the PR the tests were passing and only a single POST request was being made with all relevant data being shipped within that single request, but shortly after a change was landed which introduced this second request.
The text was updated successfully, but these errors were encountered: