Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Add missing cms links #13683

Merged
merged 40 commits into from
Jun 2, 2020
Merged

[Examples] Add missing cms links #13683

merged 40 commits into from
Jun 2, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Jun 2, 2020 •
edited

This was a change that I forgot to push into the Agility CMS example PR, adding it now.

jamesvidler and others added 30 commits April 11, 2020 15:34
@jamesvidler
initial check-in of agility-cms example
ea365ba
@jamesvidler
updated readme
a728d3c
@jamesvidler
updated environment var names
a93b6b6
@jamesvidler
added explicit preview for blogs
63e0a54
@jamesvidler
Updated readme, added preview bar to homepage
90b4441
@jamesvidler
updated readme
240b50d
@jamesvidler
added preview link to the readme
af04592
@jamesvidler
fixed typo in readme
f9ba177
@jamesvidler
added page management and updated preview
4924457
@jamesvidler
updated readme
14e7c47
@jamesvidler
udpated doc
7d0d258
@jamesvidler
fixed steps in readme
939aef0
@jamesvidler
updated step numbers in read me
849d72f
@jamesvidler
added fix for null author if author is not set or published
1831692
@jamesvidler
bug fix for static paths returning folders
7d9d4aa
Merge pull request vercel#1 from agility/cms-agilitycms-pagemanagement
71e8003 
Cms agilitycms pagemanagement
@lfades
Merge branch 'canary' of https://github.com/zeit/next.js into agility…
3d5feab 
…/canary
@lfades
Updated readme
b011921
@lfades
Lint fix and other fixes
d25f7dd
@lfades
Updated more steps
3bbaf38
@lfades
More step updates
ff86fe3
@lfades
updated more steps
a4a8490
@lfades
Updated steps
4864da1
@lfades
Added getClient method
f22abb9
@lfades
Separate client code from server code
f30b00a
@lfades
Added key
6f0b29a
@lfades
Updated final steps and replaced now.json with vercel.json
6bf55b4
@lfades
Updated links
8861e1c
@lfades
Use the router to redirect to preview
3a52502
@lfades
Fix
12b6e2f
@lfades lfades requested a review from Timer as a code owner June 2, 2020 17:13
@Timer Timer added this to the 9.4.5 milestone Jun 2, 2020
@Timer Timer added the examples Issue/PR related to examples label Jun 2, 2020
@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary lfades/next.js missing-cms-changes Change
buildDuration 14.5s 14.1s -400ms
nodeModulesSize 66.3 MB 66.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary lfades/next.js missing-cms-changes Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.511 2.545 ⚠️ +0.03
/ avg req/sec 995.68 982.32 -13.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.603 1.553 -0.05
/error-in-render avg req/sec 1559.12 1609.63 ⚠️ +50.51
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js missing-cms-changes Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js missing-cms-changes Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js missing-cms-changes Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js missing-cms-changes Change
buildDuration 15.1s 15.5s ⚠️ +475ms
nodeModulesSize 66.3 MB 66.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js missing-cms-changes Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js missing-cms-changes Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js missing-cms-changes Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js missing-cms-changes Change
buildDuration 14.2s 13.7s -512ms
nodeModulesSize 66.3 MB 66.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js missing-cms-changes Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.411 2.434 ⚠️ +0.02
/ avg req/sec 1036.82 1027.07 -9.75
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.531 1.619 ⚠️ +0.09
/error-in-render avg req/sec 1633.01 1543.76 -89.25
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js missing-cms-changes Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js missing-cms-changes Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js missing-cms-changes Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js missing-cms-changes Change
buildDuration 14.8s 14.6s -143ms
nodeModulesSize 66.3 MB 66.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js missing-cms-changes Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js missing-cms-changes Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js missing-cms-changes Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js missing-cms-changes Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@kodiakhq kodiakhq bot merged commit ef22a8b into vercel:canary Jun 2, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@lfades @rokinsky
[Examples] Add missing cms links (vercel#13683)
98d6ac4 
This was a change that I forgot to push into the Agility CMS example PR, adding it now.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode chibicode approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lfades @ijjk @Timer @chibicode @jamesvidler