enhance-with-redux-saga #13764

todortotev · 2020-06-04T15:48:19Z

Removed getInitialProps from _app

ijjk · 2020-06-04T15:55:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	11s	10.7s	-329ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.933	1.965	⚠️ +0.03
/ avg req/sec	1293.03	1272.22	-20.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.353	1.205	-0.15
/error-in-render avg req/sec	1847.86	2073.91	⚠️ +226.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	11.5s	12s	⚠️ +533ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

mattcarlotta · 2020-06-04T17:33:06Z

@todortotev Just a heads up, the next-redux-wrapper will still use getInitialProps if you extend from next/app. From the README's Usage (see second Same code in JavaScript (without types) example for fix):

Next.js provides generic getInitialProps when using class MyApp extends App which will be picked up by wrapper, so you must not extend App as you'll be opted out of Automatic Static Optimization: https://err.sh/next.js/opt-out-auto-static-optimization. Just export a regular Functional Component as in the example above.

lfades · 2020-06-04T20:13:23Z

@kirill-konshin Can you check why this example doesn't work when _app is replaced with the following:

function App({ Component, pageProps }) {
  return <Component {...pageProps} />
}

export default wrapper.withRedux(App)

I've done some debugging over this and looks like the state in pages/index.js is properly added in the store, but the client never gets the initial state

kirill-konshin · 2020-06-04T21:00:24Z

@lfades it has been fixed in 6.0.1 and also I found one other minor issue, and just pushed 6.0.2.

lfades

@kirill-konshin @todortotev I've updated the example to remove code and notes in the readme that are no longer required, it looks good to me now 😌

ijjk · 2020-06-04T22:37:17Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	12.7s	12.5s	-224ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.208	2.24	⚠️ +0.03
/ avg req/sec	1132.39	1115.83	-16.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.408	1.42	⚠️ +0.01
/error-in-render avg req/sec	1776.17	1760.62	-15.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	13.7s	13.4s	-262ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

ijjk · 2020-06-04T22:39:13Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	12.8s	13s	⚠️ +201ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.361	2.31	-0.05
/ avg req/sec	1058.7	1082.19	⚠️ +23.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.45	1.482	⚠️ +0.03
/error-in-render avg req/sec	1724.42	1686.57	-37.85

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	14.2s	14s	-291ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

ijjk · 2020-06-05T14:40:42Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	12.1s	12.4s	⚠️ +249ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.065	2.13	⚠️ +0.06
/ avg req/sec	1210.84	1173.83	-37.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.209	1.2	-0.01
/error-in-render avg req/sec	2068.07	2083.06	⚠️ +14.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	13.2s	13.3s	⚠️ +149ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

ijjk · 2020-06-05T14:49:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	12.1s	11.6s	-463ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.041	2.048	⚠️ +0.01
/ avg req/sec	1225.15	1220.72	-4.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.208	1.159	-0.05
/error-in-render avg req/sec	2070.37	2156.17	⚠️ +85.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
buildDuration	12.5s	12.7s	⚠️ +163ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-redux-saga	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

[11014](vercel#11014) Removed getInitialProps from _app

applied requested changes

d9c678b

todortotev requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners June 4, 2020 15:48

todortotev changed the title ~~applied requested changes~~ enhance-with-redux-saga Jun 4, 2020

Timer added the examples Issue/PR related to examples label Jun 4, 2020

lfades added 3 commits June 4, 2020 17:27

Updated deps and removed es6promise

d6ba38e

Removed unrequired code

1922014

Removed notes about next-redux-saga

b84a848

lfades approved these changes Jun 4, 2020

View reviewed changes

Merge branch 'canary' into enhance-with-redux-saga

0a079e0

Timer added this to the 9.4.5 milestone Jun 5, 2020

Merge branch 'canary' into enhance-with-redux-saga

84baf9e

Merge branch 'canary' into enhance-with-redux-saga

0210130

kodiakhq bot merged commit 22b2920 into vercel:canary Jun 5, 2020

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

enhance-with-redux-saga (vercel#13764)

bd13f43

[11014](vercel#11014) Removed getInitialProps from _app

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance-with-redux-saga #13764

enhance-with-redux-saga #13764

todortotev commented Jun 4, 2020

ijjk commented Jun 4, 2020

mattcarlotta commented Jun 4, 2020

lfades commented Jun 4, 2020

kirill-konshin commented Jun 4, 2020

lfades left a comment

ijjk commented Jun 4, 2020

ijjk commented Jun 4, 2020

ijjk commented Jun 5, 2020

ijjk commented Jun 5, 2020

enhance-with-redux-saga #13764

enhance-with-redux-saga #13764

Conversation

todortotev commented Jun 4, 2020

ijjk commented Jun 4, 2020

Stats from current PR

mattcarlotta commented Jun 4, 2020

lfades commented Jun 4, 2020

kirill-konshin commented Jun 4, 2020

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jun 4, 2020

Stats from current PR

ijjk commented Jun 4, 2020

Stats from current PR

ijjk commented Jun 5, 2020

Stats from current PR

ijjk commented Jun 5, 2020

Stats from current PR