[Examples] remove getInitialProps from with-firebase-authentication #13895

todortotev · 2020-06-08T08:53:24Z

Related to 11014

ijjk · 2020-06-08T09:01:31Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	11.4s	12.1s	⚠️ +679ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.131	2.064	-0.07
/ avg req/sec	1173.31	1211.22	⚠️ +37.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.318	1.398	⚠️ +0.08
/error-in-render avg req/sec	1897.08	1788.03	-109.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9545.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	13.2s	16.8s	⚠️ +3.6s
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9545.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_error.js	877 kB	877 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

examples/with-firebase-authentication/pages/index.js

todortotev · 2020-06-11T07:54:29Z

@lfades Applied the requested changes, also I have made some additional changes that I feel will make the example better. I have added a useUser hook which will facilitate the methods related to user and the concrete user data.

ijjk · 2020-06-11T08:00:28Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	13.2s	13.4s	⚠️ +123ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.393	2.231	-0.16
/ avg req/sec	1044.6	1120.65	⚠️ +76.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.663	1.498	-0.17
/error-in-render avg req/sec	1503.25	1669.06	⚠️ +165.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f367.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	7.27 kB	7.27 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.html gzip	896 B	896 B	✓
link.html gzip	902 B	902 B	✓
withRouter.html gzip	889 B	889 B	✓
Overall change	2.69 kB	2.69 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	14.3s	14.2s	-117ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f367.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	7.27 kB	7.27 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_error.js	875 kB	875 kB	✓
404.html	4.13 kB	4.13 kB	✓
hooks.html	3.71 kB	3.71 kB	✓
index.js	875 kB	875 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

ijjk · 2020-06-11T08:01:17Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	11.4s	11.5s	⚠️ +39ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.925	1.921	0
/ avg req/sec	1298.77	1301.54	⚠️ +2.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.084	1.111	⚠️ +0.03
/error-in-render avg req/sec	2306.74	2249.36	-57.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f367.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	7.27 kB	7.27 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.html gzip	896 B	896 B	✓
link.html gzip	902 B	902 B	✓
withRouter.html gzip	889 B	889 B	✓
Overall change	2.69 kB	2.69 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	12.8s	12.4s	-343ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f367.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	7.27 kB	7.27 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_error.js	875 kB	875 kB	✓
404.html	4.13 kB	4.13 kB	✓
hooks.html	3.71 kB	3.71 kB	✓
index.js	875 kB	875 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

ijjk · 2020-06-11T17:12:17Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	12.1s	11.9s	-206ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.043	1.943	-0.1
/ avg req/sec	1223.68	1286.38	⚠️ +62.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.162	1.198	⚠️ +0.04
/error-in-render avg req/sec	2151.84	2087.36	-64.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	12.9s	13s	⚠️ +80ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

lfades

Thank you!

ijjk · 2020-06-11T17:33:41Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	13s	12.9s	-165ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.224	2.158	-0.07
/ avg req/sec	1124.1	1158.43	⚠️ +34.33
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.429	1.478	⚠️ +0.05
/error-in-render avg req/sec	1749.71	1691.88	-57.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
buildDuration	14.2s	13.9s	-377ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js enhance-with-firebase-authentication	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

…ercel#13895) Related to [11014](vercel#11014)

todortotev added 6 commits June 8, 2020 11:48

Refactored the home component

a8225aa

No longer needed

564db0f

new api call

8ed6a05

improved signup flow

d9045aa

removed redundant proptypes

e1588db

proper logout flow

aa1d421

todortotev requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners June 8, 2020 08:53

ijjk added the examples Issue/PR related to examples label Jun 8, 2020

lfades reviewed Jun 8, 2020

View reviewed changes

examples/with-firebase-authentication/pages/index.js Outdated Show resolved Hide resolved

Timer assigned lfades Jun 9, 2020

todortotev added 9 commits June 11, 2020 10:39

added swr and removed dotenv

ed7cb20

added useUser hook

e753ce4

added logout to the useUser hook

21bb7f6

no longer needed

2c12355

no longer needed

fcad1f4

refactored the home page fetching

41d12b2

typo

25ce4ef

redundant

563147a

no longer needed

d3d6675

Minor updates

0fb1673

lfades approved these changes Jun 11, 2020

View reviewed changes

Merge branch 'canary' into enhance-with-firebase-authentication

a9e96d9

kodiakhq bot merged commit 6c8b7cd into vercel:canary Jun 11, 2020

darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020

[Examples] remove getInitialProps from with-firebase-authentication (v…

e0c7838

…ercel#13895) Related to [11014](vercel#11014)

ndom91 mentioned this pull request Jun 22, 2020

Suggestion: Separate next.js example updates / core updates in release notes #14472

Closed

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

[Examples] remove getInitialProps from with-firebase-authentication (v…

e7a5264

…ercel#13895) Related to [11014](vercel#11014)

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Examples] remove getInitialProps from with-firebase-authentication #13895

[Examples] remove getInitialProps from with-firebase-authentication #13895

todortotev commented Jun 8, 2020

ijjk commented Jun 8, 2020

todortotev commented Jun 11, 2020 •

edited

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

lfades left a comment

ijjk commented Jun 11, 2020

[Examples] remove getInitialProps from with-firebase-authentication #13895

[Examples] remove getInitialProps from with-firebase-authentication #13895

Conversation

todortotev commented Jun 8, 2020

ijjk commented Jun 8, 2020

Stats from current PR

todortotev commented Jun 11, 2020 • edited

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jun 11, 2020

Stats from current PR

todortotev commented Jun 11, 2020 •

edited