Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable shadowing in blog-starter example #13988

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Fix variable shadowing in blog-starter example #13988

merged 2 commits into from
Jun 10, 2020

Conversation

jamesmosier
Copy link
Contributor

@jamesmosier jamesmosier commented Jun 10, 2020 •
edited

Sorry for the super trivial PR. I noticed this while working with the example and figured it might be worth fixing.

@ijjk ijjk added the examples Issue/PR related to examples label Jun 10, 2020
lfades
lfades approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this terrible variable name 👌

@ijjk
Copy link
Member

ijjk commented Jun 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary jamesmosier/next.js patch-1 Change
buildDuration 11.1s 11.1s ⚠️ +43ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesmosier/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.859 1.894 ⚠️ +0.03
/ avg req/sec 1345 1320.19 -24.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.094 1.088 -0.01
/error-in-render avg req/sec 2284.16 2297.35 ⚠️ +13.19
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary jamesmosier/next.js patch-1 Change
index.html gzip 901 B 901 B ✓
link.html gzip 907 B 907 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary jamesmosier/next.js patch-1 Change
buildDuration 11.9s 12s ⚠️ +42ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary jamesmosier/next.js patch-1 Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesmosier/next.js patch-1 Change
buildDuration 13.1s 12s -1.1s
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary jamesmosier/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.224 2.169 -0.06
/ avg req/sec 1124.29 1152.57 ⚠️ +28.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.445 1.418 -0.03
/error-in-render avg req/sec 1730.34 1762.56 ⚠️ +32.22
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary jamesmosier/next.js patch-1 Change
index.html gzip 901 B 901 B ✓
link.html gzip 907 B 907 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary jamesmosier/next.js patch-1 Change
buildDuration 13.1s 12.3s -780ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary jamesmosier/next.js patch-1 Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓

@kodiakhq kodiakhq bot merged commit aed8b37 into vercel:canary Jun 10, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@jamesmosier @rokinsky
Fix variable shadowing in blog-starter example (vercel#13988)
8300c90 
Sorry for the super trivial PR. I noticed this while working with the example and figured it might be worth fixing.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chibicode chibicode chibicode approved these changes

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamesmosier @ijjk @chibicode @lfades