Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/with-carbon-components #15190

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Update examples/with-carbon-components #15190

merged 6 commits into from
Jul 17, 2020

Conversation

bogy0
Copy link
Contributor

@bogy0 bogy0 commented Jul 15, 2020

The example used an outdated version of carbon components v9.

The latest got a huge facelift, new components and a lot of optimizations.
I updated the example with carbon-components v10.

@ijjk ijjk added the examples Issue/PR related to examples label Jul 15, 2020
@ijjk
Copy link
Member

ijjk commented Jul 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 12.6s 12.4s -267ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bogy0/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.986 2.038 ⚠️ +0.05
/ avg req/sec 1258.79 1226.45 ⚠️ -32.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.227 1.261 ⚠️ +0.03
/error-in-render avg req/sec 2037.94 1982.92 ⚠️ -55.02
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary bogy0/next.js patch-2 Change
index.html gzip 954 B 954 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 948 B 948 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 13.6s 13.6s ⚠️ +31ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary bogy0/next.js patch-2 Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 924 kB 924 kB ✓
routerDirect.js 918 kB 918 kB ✓
withRouter.js 918 kB 918 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: a8c0010

@ijjk
Copy link
Member

ijjk commented Jul 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 14.4s 14s -369ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bogy0/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.226 2.274 ⚠️ +0.05
/ avg req/sec 1122.99 1099.42 ⚠️ -23.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.485 1.576 ⚠️ +0.09
/error-in-render avg req/sec 1683.46 1586.43 ⚠️ -97.03
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary bogy0/next.js patch-2 Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 15.2s 14.8s -340ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary bogy0/next.js patch-2 Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: a477d9c

@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 13.5s 13.4s -107ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary bogy0/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.151 2.123 -0.03
/ avg req/sec 1162.22 1177.73 +15.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.33 1.334 0
/error-in-render avg req/sec 1880.2 1874.54 ⚠️ -5.66
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary bogy0/next.js patch-2 Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary bogy0/next.js patch-2 Change
buildDuration 14.2s 14.1s -28ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary bogy0/next.js patch-2 Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bogy0/next.js patch-2 Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary bogy0/next.js patch-2 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary bogy0/next.js patch-2 Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 20f7388

@kodiakhq kodiakhq bot merged commit f3f4ca3 into vercel:canary Jul 17, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogy0 @ijjk @Timer