Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DevServer#close doesn't close all resources #15247

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Fix DevServer#close doesn't close all resources #15247

merged 2 commits into from
Jul 17, 2020

Conversation

wawjr3d
Copy link
Contributor

@wawjr3d wawjr3d commented Jul 17, 2020

No description provided.

@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
buildDuration 13.3s 13.3s ⚠️ +56ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +123 B
Page Load Tests Overall increase ✓
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.283 2.233 -0.05
/ avg req/sec 1094.9 1119.33 +24.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.505 1.502 0
/error-in-render avg req/sec 1660.73 1664.39 +3.66
Client Bundles (main, webpack, commons)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
buildDuration 14.5s 14.2s -247ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +123 B
Client Bundles (main, webpack, commons)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
main-HASH.module.js gzip 5.8 kB 5.8 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Build Manifests
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_error.js 882 kB 882 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: cec3253

@timneutkens
Copy link
Member

Good catch! Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
buildDuration 11.9s 12s ⚠️ +79ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +123 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.85 1.911 ⚠️ +0.06
/ avg req/sec 1351.57 1308.55 ⚠️ -43.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.14 1.139 0
/error-in-render avg req/sec 2192.51 2195.08 +2.57
Client Bundles (main, webpack, commons)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5fa28c9..e19f.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-694f3fc..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
buildDuration 12.7s 12.6s -136ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +123 B
Client Bundles (main, webpack, commons)
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5fa28c9..e19f.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-694f3fc..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary wawjr3d/next.js bugfix/dev-server-close Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 9414846

@kodiakhq kodiakhq bot merged commit 7834766 into vercel:canary Jul 17, 2020
@timneutkens timneutkens mentioned this pull request Jul 17, 2020
Closed
@wawjr3d
Copy link
Contributor Author

wawjr3d commented Jul 17, 2020

You got it

@wawjr3d wawjr3d deleted the bugfix/dev-server-close branch January 2, 2021 20:39
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wawjr3d @ijjk @timneutkens