Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom webpack config docs to mention existing features #15517

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

timneutkens
Copy link
Member

Also removed the webpackDevMiddleware config option in the docs given that it can be handled using webpack's top level watchOptions key https://webpack.js.org/configuration/watch/#watchoptions

Also removed the `webpackDevMiddleware` config option in the docs given that it can be handled using webpack's top level `watchOptions` key https://webpack.js.org/configuration/watch/#watchoptions
@ijjk ijjk added type: documentation examples Issue/PR related to examples labels Jul 27, 2020
@ijjk
Copy link
Member

ijjk commented Jul 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
buildDuration 13.8s 13.6s -198ms
nodeModulesSize 66.5 MB 66.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
/ failed reqs 0 0
/ total time (seconds) 2.16 2.226 ⚠️ +0.07
/ avg req/sec 1157.61 1123.29 ⚠️ -34.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.281 1.314 ⚠️ +0.03
/error-in-render avg req/sec 1951.28 1902.55 ⚠️ -48.73
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-eea7d2a..4017.js gzip 6.72 kB 6.72 kB
polyfills-05..1236.js gzip 30.8 kB 30.8 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 87.6 kB 87.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b12b7b0..dule.js gzip 5.79 kB 5.79 kB
polyfills-05..dule.js gzip 30.8 kB 30.8 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 82.6 kB 82.6 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.66 kB 7.66 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-663e6..dule.js gzip 2.24 kB 2.24 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-69bc264..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.29 kB 5.29 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_buildManifest.js gzip 275 B 275 B
_buildManife..dule.js gzip 281 B 281 B
Overall change 556 B 556 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
index.html gzip 944 B 944 B
link.html gzip 954 B 954 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
buildDuration 14.9s 14.6s -307ms
nodeModulesSize 66.5 MB 66.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-eea7d2a..4017.js gzip 6.72 kB 6.72 kB
polyfills-05..1236.js gzip 30.8 kB 30.8 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 87.6 kB 87.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b12b7b0..dule.js gzip 5.79 kB 5.79 kB
polyfills-05..dule.js gzip 30.8 kB 30.8 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 82.6 kB 82.6 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.66 kB 7.66 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-663e6..dule.js gzip 2.24 kB 2.24 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-69bc264..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.29 kB 5.29 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_buildManifest.js gzip 275 B 275 B
_buildManife..dule.js gzip 281 B 281 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary timneutkens/next.js add/webpack-config-docs Change
_error.js 881 kB 881 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 881 kB 881 kB
link.js 922 kB 922 kB
routerDirect.js 916 kB 916 kB
withRouter.js 916 kB 916 kB
Overall change 4.52 MB 4.52 MB
Commit: 9acb80f

@timneutkens timneutkens merged commit a3eec3b into vercel:canary Jul 27, 2020
@timneutkens timneutkens deleted the add/webpack-config-docs branch July 27, 2020 09:46
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants