Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for querystring-relative urls #15911

Merged
merged 2 commits into from Aug 5, 2020
Merged

Add tests for querystring-relative urls #15911

merged 2 commits into from Aug 5, 2020

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Aug 5, 2020

Fixes #10883

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Janpot/next.js test-query-relative Change
buildDuration 11.2s 11.3s ⚠️ +105ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Janpot/next.js test-query-relative Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.117 1.987 -0.13
/ avg req/sec 1180.78 1258.41 +77.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.114 1.095 -0.02
/error-in-render avg req/sec 2243.67 2282.38 +38.71
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js test-query-relative Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js test-query-relative Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js test-query-relative Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Janpot/next.js test-query-relative Change
buildDuration 12.5s 12.7s ⚠️ +269ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js test-query-relative Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js test-query-relative Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary Janpot/next.js test-query-relative Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Commit: 8d0fefb

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Janpot/next.js test-query-relative Change
buildDuration 12.3s 12.2s -99ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Janpot/next.js test-query-relative Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.262 2.252 -0.01
/ avg req/sec 1105.22 1110 +4.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.284 ⚠️ +0.04
/error-in-render avg req/sec 2009.14 1947.65 ⚠️ -61.49
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js test-query-relative Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js test-query-relative Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js test-query-relative Change
index.html gzip 945 B 945 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Janpot/next.js test-query-relative Change
buildDuration 13.6s 14.3s ⚠️ +632ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js test-query-relative Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Janpot/next.js test-query-relative Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js test-query-relative Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary Janpot/next.js test-query-relative Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Commit: 8c1222a

@Timer Timer merged commit 17716d1 into vercel:canary Aug 5, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using router.push with non-absolute query fails as invalid href.
3 participants
@Janpot @ijjk @Timer