Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-i18n-rosetta example #16023

Merged
merged 4 commits into from Aug 10, 2020
Merged

Fix with-i18n-rosetta example #16023

merged 4 commits into from Aug 10, 2020

Conversation

StarpTech
Copy link
Contributor

This PR address the issues in #11841 (comment)

@ijjk ijjk added the examples Issue/PR related to examples label Aug 9, 2020
@StarpTech StarpTech mentioned this pull request Aug 9, 2020
Merged
@ijjk
Copy link
Member

ijjk commented Aug 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
buildDuration 11.6s 11.7s ⚠️ +99ms
nodeModulesSize 65.6 MB 65.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.152 2.148 0
/ avg req/sec 1161.58 1163.66 +2.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.27 1.332 ⚠️ +0.06
/error-in-render avg req/sec 1968.92 1876.94 ⚠️ -91.98
Client Bundles (main, webpack, commons)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-008324e..83e7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c621fe2..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
buildDuration 13s 12.6s -358ms
nodeModulesSize 65.6 MB 65.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-008324e..83e7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c621fe2..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 09a7ecb

rogerbramon
rogerbramon reviewed Aug 10, 2020
View reviewed changes
examples/with-i18n-rosetta/lib/i18n.js
}
// force rerender to update view
setTick((tick) => tick + 1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work for me. I get an Unhandled Runtime Error on setTick((tick) => tick + 1) on loading:

Unhandled Runtime Error
Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@ijjk
Copy link
Member

ijjk commented Aug 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
buildDuration 13.5s 13.5s ⚠️ +52ms
nodeModulesSize 65.7 MB 65.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.425 2.435 ⚠️ +0.01
/ avg req/sec 1030.87 1026.49 ⚠️ -4.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.596 1.466 -0.13
/error-in-render avg req/sec 1565.98 1705.83 +139.85
Client Bundles (main, webpack, commons)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-008324e..83e7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c621fe2..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
buildDuration 14.9s 14.9s -45ms
nodeModulesSize 65.7 MB 65.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-008324e..83e7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c621fe2..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary StarpTech/next.js fix/with-i18n-rosetta Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 8318727

lfades
lfades approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it worked, thank you!

@lfades lfades changed the title fix Fix with-i18n-rosetta example Aug 10, 2020
@lfades lfades merged commit 4b2a825 into vercel:canary Aug 10, 2020
@rogerbramon
Copy link

Thanks @StarpTech! Very smooth now!

@snyk-bot snyk-bot mentioned this pull request May 11, 2021
Open
This was referenced Jun 26, 2021
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogerbramon rogerbramon rogerbramon left review comments

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StarpTech @ijjk @rogerbramon @lfades