Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe ComponentRes type #16148

Merged
merged 3 commits into from Aug 13, 2020
Merged

Dedupe ComponentRes type #16148

merged 3 commits into from Aug 13, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 13, 2020

This PR dedupes the ComponentRes type to now align with the loadPage return type.

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 12.4s 12.4s -50ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +113 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js remove/component-res-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.179 2.156 -0.02
/ avg req/sec 1147.57 1159.3 +11.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.199 1.199 ✓
/error-in-render avg req/sec 2084.48 2085.84 +1.36
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ⚠️ +2 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
index.html gzip 947 B 948 B ⚠️ +1 B
link.html gzip 955 B 957 B ⚠️ +2 B
withRouter.html gzip 940 B 943 B ⚠️ +3 B
Overall change 2.84 kB 2.85 kB ⚠️ +6 B

Diffs

Diff for 677f882d2ed8..a6bebf348.js 
@@ -680,21 +680,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports["default"] = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for 677f882d2ed8..91.module.js 
@@ -539,21 +539,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports.default = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 13.9s 14s ⚠️ +29ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +113 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..b9b7.js gzip N/A 10 kB N/A
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.92 kB N/A
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js remove/component-res-type Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: b126813

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 9.3s 9.7s ⚠️ +356ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +60 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.678 1.719 ⚠️ +0.04
/ avg req/sec 1489.48 1454.02 ⚠️ -35.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.915 0.925 ⚠️ +0.01
/error-in-render avg req/sec 2733.62 2703.49 ⚠️ -30.13
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ⚠️ +2 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
index.html gzip 947 B 948 B ⚠️ +1 B
link.html gzip 955 B 957 B ⚠️ +2 B
withRouter.html gzip 940 B 943 B ⚠️ +3 B
Overall change 2.84 kB 2.85 kB ⚠️ +6 B

Diffs

Diff for 677f882d2ed8..a6bebf348.js 
@@ -680,21 +680,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports["default"] = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for 677f882d2ed8..91.module.js 
@@ -539,21 +539,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports.default = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 10.6s 10.5s -104ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +60 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..b9b7.js gzip N/A 10 kB N/A
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.92 kB N/A
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js remove/component-res-type Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 21e7715

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 14.5s 13.7s -895ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +60 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js remove/component-res-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.763 2.56 -0.2
/ avg req/sec 904.96 976.42 +71.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.592 1.52 -0.07
/error-in-render avg req/sec 1570.69 1645.22 +74.53
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ⚠️ +2 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
index.html gzip 947 B 948 B ⚠️ +1 B
link.html gzip 955 B 957 B ⚠️ +2 B
withRouter.html gzip 940 B 943 B ⚠️ +3 B
Overall change 2.84 kB 2.85 kB ⚠️ +6 B

Diffs

Diff for 677f882d2ed8..a6bebf348.js 
@@ -680,21 +680,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports["default"] = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for 677f882d2ed8..91.module.js 
@@ -539,21 +539,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.markLoadingError = markLoadingError;
       exports.default = void 0;
 
+      var _normalizeTrailingSlash = __webpack_require__("X24+");
+
       var _mitt = _interopRequireDefault(__webpack_require__("dZ6Y"));
 
       var _utils = __webpack_require__("g/15");
 
       var _isDynamic = __webpack_require__("/jkW");
 
-      var _routeMatcher = __webpack_require__("gguc");
-
-      var _routeRegex = __webpack_require__("YTqd");
+      var _parseRelativeUrl = __webpack_require__("hS4m");
 
       var _querystring = __webpack_require__("3WeD");
 
-      var _parseRelativeUrl = __webpack_require__("hS4m");
+      var _routeMatcher = __webpack_require__("gguc");
 
-      var _normalizeTrailingSlash = __webpack_require__("X24+");
+      var _routeRegex = __webpack_require__("YTqd");
 
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
buildDuration 16.5s 15.4s -1.1s
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +60 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..ee8a.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..b9b7.js gzip N/A 10 kB N/A
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/component-res-type Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.92 kB N/A
Overall change 51.6 kB 51.6 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/component-res-type Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/component-res-type Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/component-res-type Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js remove/component-res-type Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: b70c807

@kodiakhq kodiakhq bot merged commit c7acd11 into vercel:canary Aug 13, 2020
@Timer Timer deleted the remove/component-res-type branch August 13, 2020 05:58
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@Timer
Dedupe ComponentRes type (vercel#16148)
f4b5f53 
This PR dedupes the `ComponentRes` type to now align with the `loadPage` return type.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @ijjk @lfades