Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing statusCode for GS(S)P redirect #18422

Merged
merged 5 commits into from Nov 2, 2020
Merged

Allow passing statusCode for GS(S)P redirect #18422

merged 5 commits into from Nov 2, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 28, 2020

This adds support for passing statusCode in a redirect from getServerSideProps or getStaticProps which matches the redirect shape allowed to be returned for redirects in next.config.js

Closes: #18350

@ijjk
Copy link
Member Author

ijjk commented Oct 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 12.6s 12.9s ⚠️ +354ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +1.84 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.4 2.464 ⚠️ +0.06
/ avg req/sec 1041.56 1014.51 ⚠️ -27.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.304 1.232 -0.07
/error-in-render avg req/sec 1917.2 2028.43 +111.23
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-20f9619..dule.js gzip 6.31 kB 6.31 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 14.7s 14.5s -185ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +1.84 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-20f9619..dule.js gzip 6.31 kB 6.31 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_error.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
link.js 1.11 MB 1.12 MB ⚠️ +9.56 kB
routerDirect.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
withRouter.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
Overall change 5.43 MB 5.48 MB ⚠️ +47.8 kB
Commit: e563ccc

Timer
Timer requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docs in this same PR

Timer
Timer previously approved these changes Nov 2, 2020
View reviewed changes
@ijjk ijjk requested a review from chibicode as a code owner November 2, 2020 20:45
@ijjk ijjk requested a review from Timer November 2, 2020 20:45
@ijjk
Copy link
Member Author

ijjk commented Nov 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 11.2s 11.3s ⚠️ +97ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.114 2.096 -0.02
/ avg req/sec 1182.71 1192.88 +10.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.179 1.177 0
/error-in-render avg req/sec 2120.36 2123.96 +3.6
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 12.7s 12.7s ⚠️ +61ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_error.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
link.js 1.11 MB 1.12 MB ⚠️ +9.56 kB
routerDirect.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
withRouter.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
Overall change 5.44 MB 5.48 MB ⚠️ +47.8 kB
Commit: 88f24d4

@ijjk
Copy link
Member Author

ijjk commented Nov 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 12.7s 12.4s -294ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.345 2.335 -0.01
/ avg req/sec 1065.92 1070.88 +4.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.257 ⚠️ +0.01
/error-in-render avg req/sec 2009.9 1989.06 ⚠️ -20.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 14.2s 14s -250ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_error.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
link.js 1.11 MB 1.12 MB ⚠️ +9.56 kB
routerDirect.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
withRouter.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
Overall change 5.44 MB 5.48 MB ⚠️ +47.8 kB
Commit: 5aa6dce

@ijjk
Copy link
Member Author

ijjk commented Nov 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 11.5s 11.7s ⚠️ +178ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.203 2.181 -0.02
/ avg req/sec 1134.98 1146.26 +11.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.174 1.147 -0.03
/error-in-render avg req/sec 2129.67 2180.53 +50.86
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
buildDuration 13.1s 12.6s -461ms
nodeModulesSize 90 MB 90 MB ⚠️ +1.84 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..4b86.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-bdd7564..bfa7.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e70a6ce..dule.js gzip 6.35 kB 6.35 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js redirect/allow-status-code Change
_error.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.07 MB ⚠️ +9.56 kB
link.js 1.11 MB 1.12 MB ⚠️ +9.56 kB
routerDirect.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
withRouter.js 1.1 MB 1.11 MB ⚠️ +9.56 kB
Overall change 5.44 MB 5.48 MB ⚠️ +47.8 kB
Commit: 8b24359

@kodiakhq kodiakhq bot merged commit c8d26ed into vercel:canary Nov 2, 2020
@ijjk ijjk deleted the redirect/allow-status-code branch November 2, 2020 21:53
@foooomio foooomio mentioned this pull request Nov 6, 2020
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@chibicode chibicode Awaiting requested review from chibicode

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change TEMPORARY_REDIRECT_STATUS to 303
2 participants
@ijjk @Timer