Extend IncomingMessage type to include cookies from middleware #19724

mattfwood · 2020-12-02T01:32:40Z

When using getServerSideProps with Typescript, it looks like it's expecting req to be a plain IncomingMessage from http, but Next middleware (?) is adding cookies:

Here's a reproduction showing the example:

https://codesandbox.io/s/nextjs-server-side-props-cookies-vr547?file=/pages/index.tsx

In the terminal, you can see that there is a value for cookies, but IncomingMessage doesn't include it by default.

I still need to get more familiar with all the Next.js internals, but I imagine there are a few other places where this type could be used if cookies are being included. Any help would be appreciated.

ijjk · 2020-12-02T01:42:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.1s	10.8s	-208ms
nodeModulesSize	85 MB	85 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.328	2.302	-0.03
/ avg req/sec	1073.8	1086.09	+12.29
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.688	1.575	-0.11
/error-in-render avg req/sec	1480.74	1587.56	+106.82

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..8b6e.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3c9ff84..1d7c.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	12.8s	12.6s	-161ms
nodeModulesSize	85 MB	85 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..8b6e.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3c9ff84..1d7c.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	997 kB	997 kB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	998 kB	998 kB	✓
link.js	1.05 MB	1.05 MB	✓
routerDirect.js	1.04 MB	1.04 MB	✓
withRouter.js	1.04 MB	1.04 MB	✓
Overall change	5.14 MB	5.14 MB	✓

Commit: edcc50a

ijjk · 2020-12-03T19:08:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	9.6s	9.6s	-38ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.004	1.936	-0.07
/ avg req/sec	1247.74	1291.08	+43.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.255	1.197	-0.06
/error-in-render avg req/sec	1992.55	2088.71	+96.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..8b6e.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3c9ff84..1d7c.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.7s	11.5s	-201ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..8b6e.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3c9ff84..1d7c.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	997 kB	997 kB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	998 kB	998 kB	✓
link.js	1.05 MB	1.05 MB	✓
routerDirect.js	1.04 MB	1.04 MB	✓
withRouter.js	1.04 MB	1.04 MB	✓
Overall change	5.14 MB	5.14 MB	✓

Commit: b436967

ijjk · 2020-12-04T17:54:27Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	10.5s	10.4s	-29ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.792	2.482	-0.31
/ avg req/sec	895.46	1007.22	+111.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.604	1.284	-0.32
/error-in-render avg req/sec	1558.17	1947.01	+388.84

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.27 kB	8.27 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	13s	12.6s	-434ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.27 kB	8.27 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 71e7a27

ijjk · 2020-12-08T16:07:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	9s	9s	⚠️ +56ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.112	2.149	⚠️ +0.04
/ avg req/sec	1183.77	1163.13	⚠️ -20.64
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.143	1.133	-0.01
/error-in-render avg req/sec	2186.48	2206.29	+19.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	10.4s	10.4s	-56ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: eceba3f

ijjk · 2020-12-08T16:08:20Z

Failing test suites

Commit: eceba3f

test/integration/dist-dir/test/index.test.js

distDir > should handle null/undefined distDir

Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 106

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

ijjk · 2020-12-08T16:49:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	9.9s	9.9s	-1ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.388	2.348	-0.04
/ avg req/sec	1046.76	1064.55	+17.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.308	1.203	-0.1
/error-in-render avg req/sec	1910.61	2078.01	+167.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.8s	11.4s	-441ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: e2b1933

ijjk · 2020-12-10T00:27:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	8.5s	8.6s	⚠️ +123ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.095	2.076	-0.02
/ avg req/sec	1193.31	1204.12	+10.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.083	1.105	⚠️ +0.02
/error-in-render avg req/sec	2308.48	2263.32	⚠️ -45.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	10.4s	10.3s	-128ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: f330496

ijjk · 2020-12-10T20:46:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	9.8s	9.4s	-478ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.493	2.377	-0.12
/ avg req/sec	1002.85	1051.68	+48.83
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.262	1.19	-0.07
/error-in-render avg req/sec	1981.67	2101.21	+119.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3e8cb31..cddc.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.8s	11.7s	-49ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3e8cb31..cddc.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 2550d1f

ijjk · 2020-12-12T03:09:01Z

Failing test suites

Commit: b59ac7f

test/integration/dist-dir/test/index.test.js

distDir > should handle null/undefined distDir

Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 106

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

ijjk · 2020-12-15T18:00:10Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	10.9s	10.7s	-194ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.524	2.53	⚠️ +0.01
/ avg req/sec	990.44	988.26	⚠️ -2.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.365	1.31	-0.05
/error-in-render avg req/sec	1831.2	1907.72	+76.52

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..0679.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b992ce4..2479.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	13.6s	12.2s	-1.3s
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..0679.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b992ce4..2479.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: ac14340

ijjk · 2020-12-17T20:02:12Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	8.9s	8.9s	-52ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.124	2.078	-0.05
/ avg req/sec	1177.23	1202.92	+25.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.092	1.11	⚠️ +0.02
/error-in-render avg req/sec	2289.33	2252.95	⚠️ -36.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.5s	11.1s	-464ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +104 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 115cade

timneutkens · 2020-12-18T11:10:55Z

Thanks! I've added a test and made some changes 👍

ijjk · 2020-12-18T11:19:00Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	10.1s	10s	-58ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +45 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.371	2.379	⚠️ +0.01
/ avg req/sec	1054.32	1051.03	⚠️ -3.29
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.267	1.26	-0.01
/error-in-render avg req/sec	1972.41	1984.12	+11.71

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
buildDuration	11.8s	11.7s	-98ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +45 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	mattfwood/next.js fix/incoming-message-cookies-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 3145c45

…as NextApiRequest.cookies (#21336) The original type for `GetServerSidePropsContext.req.cookies` was introduced in #19724. In the PR, the test at `test/integration/typescript/test/index.test.js` expects req.cookies to always exist, so `req.cookies` will never be undefined. I'm guessing that req.cookies is parsed using the same cookie middleware as `NextApiRequest`, in which case `req.cookies` should be `{ [key: string]: string }`, not `{ [key: string]: any }`.

matt-cratebind added 2 commits December 1, 2020 19:19

Extend IncomingMessage type to include cookies from middleware

2ba058d

Extract extended IncomingMessage to its own type

edcc50a

mattfwood requested review from ijjk, lfades, Timer and timneutkens as code owners December 2, 2020 01:32

ijjk added the type: next label Dec 2, 2020

vercel bot temporarily deployed to Preview December 2, 2020 01:32 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

b436967

vercel bot temporarily deployed to Preview December 3, 2020 18:59 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

71e7a27

vercel bot temporarily deployed to Preview December 4, 2020 17:45 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

eceba3f

vercel bot temporarily deployed to Preview December 8, 2020 15:59 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

e2b1933

vercel bot temporarily deployed to Preview December 8, 2020 16:41 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

f330496

vercel bot temporarily deployed to Preview December 10, 2020 00:20 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

2550d1f

vercel bot temporarily deployed to Preview December 10, 2020 20:37 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

9abb686

vercel bot temporarily deployed to Preview December 11, 2020 16:06 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

ac14340

vercel bot temporarily deployed to Preview December 15, 2020 17:50 Inactive

Merge branch 'canary' into fix/incoming-message-cookies-type

115cade

vercel bot temporarily deployed to Preview December 17, 2020 19:53 Inactive

Add test and remove export

bb7449e

timneutkens dismissed a stale review via bb7449e December 18, 2020 11:06

vercel bot temporarily deployed to Preview December 18, 2020 11:06 Inactive

timneutkens approved these changes Dec 18, 2020

View reviewed changes

Merge branch 'canary' into fix/incoming-message-cookies-type

3145c45

vercel bot temporarily deployed to Preview December 18, 2020 11:10 Inactive

kodiakhq bot merged commit 7d48241 into vercel:canary Dec 18, 2020

This was referenced Dec 23, 2020

Apply API middlewares to getServerSideProps #11126

Closed

Add deprecation notice due to Next.js 10.0.4 having cookies in getServerSideProps? matthewmueller/next-cookies#38

Closed

Meemaw mentioned this pull request Jan 3, 2021

fix: add req.cookies property in "getServerSideProps" next-page-tester/next-page-tester#85

Merged

2 tasks

andrehsu mentioned this pull request Jan 19, 2021

Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

Merged

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend IncomingMessage type to include cookies from middleware #19724

Extend IncomingMessage type to include cookies from middleware #19724

mattfwood commented Dec 2, 2020

ijjk commented Dec 2, 2020

ijjk commented Dec 3, 2020

ijjk commented Dec 4, 2020

ijjk commented Dec 8, 2020

ijjk commented Dec 8, 2020

ijjk commented Dec 8, 2020

ijjk commented Dec 10, 2020

ijjk commented Dec 10, 2020

ijjk commented Dec 12, 2020

ijjk commented Dec 15, 2020

ijjk commented Dec 17, 2020

timneutkens commented Dec 18, 2020

ijjk commented Dec 18, 2020

Extend IncomingMessage type to include cookies from middleware #19724

Extend IncomingMessage type to include cookies from middleware #19724

Conversation

mattfwood commented Dec 2, 2020

ijjk commented Dec 2, 2020

Stats from current PR

ijjk commented Dec 3, 2020

Stats from current PR

ijjk commented Dec 4, 2020

Stats from current PR

ijjk commented Dec 8, 2020

Stats from current PR

ijjk commented Dec 8, 2020

Failing test suites

ijjk commented Dec 8, 2020

Stats from current PR

ijjk commented Dec 10, 2020

Stats from current PR

ijjk commented Dec 10, 2020

Stats from current PR

ijjk commented Dec 12, 2020

Failing test suites

ijjk commented Dec 15, 2020

Stats from current PR

ijjk commented Dec 17, 2020

Stats from current PR

timneutkens commented Dec 18, 2020

ijjk commented Dec 18, 2020

Stats from current PR