Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example with-mdbreact #19879

Merged
merged 4 commits into from Dec 31, 2020
Merged

example with-mdbreact #19879

merged 4 commits into from Dec 31, 2020

Conversation

enochndika
Copy link
Contributor

This example illustrates how to integrate mdbreact (material design bootstrap for react) with next.js

@ijjk ijjk added the examples Issue/PR related to examples label Dec 5, 2020
@vercel vercel bot temporarily deployed to Preview December 5, 2020 20:57 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 5, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 10.2s 10.2s ⚠️ +68ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary enochndika/next.js example-by-enoch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.393 2.499 ⚠️ +0.11
/ avg req/sec 1044.53 1000.31 ⚠️ -44.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.356 1.323 -0.03
/error-in-render avg req/sec 1844.06 1890.17 +46.11
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary enochndika/next.js example-by-enoch Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 12.5s 12.5s -82ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary enochndika/next.js example-by-enoch Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 0bbf27a

@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 9.6s 9.4s -221ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary enochndika/next.js example-by-enoch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.972 1.973 0
/ avg req/sec 1267.66 1267.02 ⚠️ -0.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.24 1.204 -0.04
/error-in-render avg req/sec 2016.35 2076.97 +60.62
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary enochndika/next.js example-by-enoch Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 11.3s 11.6s ⚠️ +278ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary enochndika/next.js example-by-enoch Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 4b5ddb7

lfades
lfades approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 💯

@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 11.5s 11.1s -343ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary enochndika/next.js example-by-enoch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.257 2.274 ⚠️ +0.02
/ avg req/sec 1107.71 1099.49 ⚠️ -8.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.648 1.639 -0.01
/error-in-render avg req/sec 1517.12 1525.13 +8.01
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary enochndika/next.js example-by-enoch Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary enochndika/next.js example-by-enoch Change
buildDuration 13.7s 13.4s -236ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary enochndika/next.js example-by-enoch Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary enochndika/next.js example-by-enoch Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary enochndika/next.js example-by-enoch Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary enochndika/next.js example-by-enoch Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary enochndika/next.js example-by-enoch Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: fb3170c

@kodiakhq kodiakhq bot merged commit 44ee7de into vercel:canary Dec 31, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enochndika @ijjk @lfades