Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link documentation #19980

Merged
merged 4 commits into from Dec 14, 2020
Merged

Update Link documentation #19980

merged 4 commits into from Dec 14, 2020

Conversation

blvdmitry
Copy link
Contributor

Mention onClick property for next/link wrapping custom components

Mention onClick property for Link wrapping custom components
@vercel vercel bot temporarily deployed to Preview December 8, 2020 21:17 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 8, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 10.2s 9.8s -332ms
nodeModulesSize 82.5 MB 82.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary blvdmitry/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.324 2.342 ⚠️ +0.02
/ avg req/sec 1075.83 1067.29 ⚠️ -8.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.263 1.224 -0.04
/error-in-render avg req/sec 1979.08 2043.17 +64.09
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB
_error-01375..90b6.js gzip 3.69 kB 3.69 kB
hooks-d4591d..e7c2.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB
routerDirect..fd29.js gzip 303 B 303 B
withRouter-b..76ae.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Rendered Page Sizes
vercel/next.js canary blvdmitry/next.js patch-1 Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 11.9s 11.9s ⚠️ +36ms
nodeModulesSize 82.5 MB 82.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB
_error-01375..90b6.js gzip 3.69 kB 3.69 kB
hooks-d4591d..e7c2.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB
routerDirect..fd29.js gzip 303 B 303 B
withRouter-b..76ae.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Serverless bundles
vercel/next.js canary blvdmitry/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 8d50849

@vercel vercel bot temporarily deployed to Preview December 12, 2020 17:32 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 10.9s 10.9s -32ms
nodeModulesSize 82.5 MB 82.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary blvdmitry/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.794 2.733 -0.06
/ avg req/sec 894.7 914.67 +19.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.64 1.631 -0.01
/error-in-render avg req/sec 1524.43 1532.46 +8.03
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..c0a8.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB
_error-01375..90b6.js gzip 3.69 kB 3.69 kB
hooks-d4591d..e7c2.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB
routerDirect..fd29.js gzip 303 B 303 B
withRouter-b..76ae.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Rendered Page Sizes
vercel/next.js canary blvdmitry/next.js patch-1 Change
index.html gzip 613 B 613 B
link.html gzip 618 B 618 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 12.6s 12.9s ⚠️ +205ms
nodeModulesSize 82.5 MB 82.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..c0a8.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB
_error-01375..90b6.js gzip 3.69 kB 3.69 kB
hooks-d4591d..e7c2.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB
routerDirect..fd29.js gzip 303 B 303 B
withRouter-b..76ae.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Serverless bundles
vercel/next.js canary blvdmitry/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 0fcd3b9

@vercel vercel bot temporarily deployed to Preview December 14, 2020 09:02 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 8.5s 8.6s ⚠️ +120ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary blvdmitry/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.007 2.001 -0.01
/ avg req/sec 1245.45 1249.62 +4.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.099 1.094 0
/error-in-render avg req/sec 2275.81 2285.05 +9.24
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary blvdmitry/next.js patch-1 Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 10.1s 10s -103ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary blvdmitry/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 3655b57

@timneutkens
Copy link
Member

Thanks!

@vercel vercel bot temporarily deployed to Preview December 14, 2020 09:43 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 8.4s 8.6s ⚠️ +276ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary blvdmitry/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.036 2.034 0
/ avg req/sec 1227.6 1229.18 +1.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.082 1.071 -0.01
/error-in-render avg req/sec 2309.77 2334.25 +24.48
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary blvdmitry/next.js patch-1 Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary blvdmitry/next.js patch-1 Change
buildDuration 10.2s 10.2s ⚠️ +55ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary blvdmitry/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary blvdmitry/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary blvdmitry/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary blvdmitry/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary blvdmitry/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 382ae1d

@kodiakhq kodiakhq bot merged commit a442841 into vercel:canary Dec 14, 2020
@blvdmitry blvdmitry deleted the patch-1 branch December 14, 2020 10:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants