Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logo for dark mode #20047

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Update logo for dark mode #20047

merged 4 commits into from
Dec 9, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Dec 9, 2020 •
edited
Loading

Closes #20046

@ijjk ijjk added the type: next label Dec 9, 2020
@vercel vercel bot temporarily deployed to Preview December 9, 2020 23:12 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
buildDuration 9.7s 9.8s ⚠️ +47ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +333 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.38 2.349 -0.03
/ avg req/sec 1050.54 1064.18 +13.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.23 1.284 ⚠️ +0.05
/error-in-render avg req/sec 2033.06 1947.26 ⚠️ -85.8
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
buildDuration 11.8s 11.4s -364ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +96 B
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 0505219

@vercel vercel bot temporarily deployed to Preview December 9, 2020 23:36 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
buildDuration 9.5s 9.7s ⚠️ +177ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +96 B
Page Load Tests Overall increase ✓
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.358 2.322 -0.04
/ avg req/sec 1060.35 1076.85 +16.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.251 1.218 -0.03
/error-in-render avg req/sec 1999 2052.1 +53.1
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
buildDuration 11.6s 11.6s -10ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +96 B
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js update-next-js-logo-in-the-readme-to-support-ch16650 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 50cb84d

@kodiakhq kodiakhq bot merged commit a5fea53 into vercel:canary Dec 9, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Next.js logo in the readme to support GitHub dark mode
2 participants
@lfades @ijjk