Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack-bundle-analyzer #20232

Merged
merged 4 commits into from
Dec 18, 2020

Conversation

TrySound
Copy link
Contributor

Ref https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md
and https://packagephobia.com/result?p=webpack-bundle-analyzer

A few major points

  • support node 10+
  • dropped express server
  • dropped ejs template engine

@vercel vercel bot temporarily deployed to Preview December 16, 2020 17:20 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 8.6s 8.7s ⚠️ +37ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
/ failed reqs 0 0
/ total time (seconds) 2.024 2.027 0
/ avg req/sec 1235.06 1233.5 ⚠️ -1.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.082 1.07 -0.01
/error-in-render avg req/sec 2311.07 2337.29 +26.22
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
index.html gzip 615 B 615 B
link.html gzip 621 B 621 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 10.1s 10.2s ⚠️ +41ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 9fa8a02

timneutkens
timneutkens previously approved these changes Dec 17, 2020
@vercel vercel bot temporarily deployed to Preview December 17, 2020 12:20 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 8.6s 9s ⚠️ +383ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
/ failed reqs 0 0
/ total time (seconds) 2.082 2.111 ⚠️ +0.03
/ avg req/sec 1200.8 1184.14 ⚠️ -16.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.14 1.11 -0.03
/error-in-render avg req/sec 2192.99 2251.83 +58.84
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 10.2s 9.9s -311ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 6789dde

@vercel vercel bot temporarily deployed to Preview December 17, 2020 14:08 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 8.7s 8.7s -25ms
nodeModulesSize 82.4 MB 82.4 MB -276 B
Page Load Tests Overall increase ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
/ failed reqs 0 0
/ total time (seconds) 2.055 2.13 ⚠️ +0.07
/ avg req/sec 1216.5 1173.65 ⚠️ -42.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.121 1.072 -0.05
/error-in-render avg req/sec 2229.83 2331.09 +101.26
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 10.2s 10s -187ms
nodeModulesSize 82.4 MB 82.4 MB -276 B
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 91d5ffe

@timneutkens
Copy link
Member

Thanks!

@vercel vercel bot temporarily deployed to Preview December 18, 2020 08:36 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 7.9s 7.9s -14ms
nodeModulesSize 82.4 MB 82.4 MB -276 B
Page Load Tests Overall increase ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
/ failed reqs 0 0
/ total time (seconds) 1.929 1.929
/ avg req/sec 1296.07 1295.93 ⚠️ -0.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.037 1.026 -0.01
/error-in-render avg req/sec 2410.85 2437.72 +26.87
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
index.html gzip 612 B 612 B
link.html gzip 619 B 619 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
buildDuration 9.3s 9.2s -60ms
nodeModulesSize 82.4 MB 82.4 MB -276 B
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-webpack-bundle-analyzer Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 29fcd0a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants