Remove import type syntax from core files #20379

ijjk · 2020-12-22T03:00:29Z

This removes import type usage from our core files since import type requires a higher TypeScript version than currently expected.

Fixes: #19300

ijjk · 2020-12-22T03:08:32Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	9s	8.9s	-70ms
nodeModulesSize	82.6 MB	82.6 MB	-85 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.668	1.76	⚠️ +0.09
/ avg req/sec	1499.19	1420.64	⚠️ -78.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.054	1.122	⚠️ +0.07
/error-in-render avg req/sec	2372.48	2227.59	⚠️ -144.89

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-72193d1..1356.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
index.html gzip	613 B	613 B	✓
link.html gzip	618 B	618 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	10.6s	9.8s	-750ms
nodeModulesSize	82.6 MB	82.6 MB	-85 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-72193d1..1356.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: a51b75d

matamatanot · 2020-12-22T08:01:02Z

@ijjk

a higher TypeScript version than currently expected.

Where is the recommended version clearly stated?
The documentation says to install the latest version.
https://nextjs.org/learn/excel/typescript/create-tsconfig

timneutkens · 2020-12-22T13:15:11Z

@ijjk

a higher TypeScript version than currently expected.

Where is the recommended version clearly stated?
The documentation says to install the latest version.
nextjs.org/learn/excel/typescript/create-tsconfig

We just saw some people having trouble upgrading from Next.js 9 when they had an older version of typescript installed and there's no ergonomic benefit in the codebase right now to justify breaking those cases.

ijjk · 2020-12-28T18:30:36Z

Failing test suites

Commit: d9cd15d

test/integration/custom-routes-i18n/test/index.test.js

Custom routes i18n > dev mode > should navigate on the client with rewrites correctly

Expand output

● Custom routes i18n › dev mode › should navigate on the client with rewrites correctly

TIMED OUT: success

undefined

  384 | 
  385 |   if (hardError) {
> 386 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  387 |   }
  388 |   return false
  389 | }

  at check (lib/next-test-utils.js:386:11)
  at Object.<anonymous> (integration/custom-routes-i18n/test/index.test.js:110:7)

test/integration/i18n-support-base-path/test/index.test.js

i18n Support basePath > serverless mode > should navigate through history with query correctly

Expand output

● i18n Support basePath › serverless mode › should navigate through history with query correctly

thrown: "Exceeded timeout of 120000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  28 | 
  29 | export function runTests(ctx) {
> 30 |   it('should navigate through history with query correctly', async () => {
     |   ^
  31 |     const browser = await webdriver(ctx.appPort, `${ctx.basePath || '/'}`)
  32 | 
  33 |     await browser.eval(`(function() {

  at runTests (integration/i18n-support/test/shared.js:30:3)
  at integration/i18n-support-base-path/test/index.test.js:191:5
  at integration/i18n-support-base-path/test/index.test.js:77:3
  at Object.<anonymous> (integration/i18n-support-base-path/test/index.test.js:24:1)

ijjk · 2020-12-28T18:30:59Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	10.2s	10.1s	-9ms
nodeModulesSize	82.6 MB	82.6 MB	-85 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.992	2.002	⚠️ +0.01
/ avg req/sec	1255.11	1249.05	⚠️ -6.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.299	1.227	-0.07
/error-in-render avg req/sec	1925.17	2037.14	+111.97

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..1e91.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	11.9s	11.9s	⚠️ +36ms
nodeModulesSize	82.6 MB	82.6 MB	-85 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..1e91.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: d9cd15d

This tweaks the new i18n query history test to address intermittent failures in CI x-ref: #19197 (comment) x-ref: #19135 (comment) x-ref: #20379 (comment)

ijjk · 2020-12-28T21:53:03Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	9.5s	10.1s	⚠️ +584ms
nodeModulesSize	82.7 MB	82.7 MB	-85 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.924	2.014	⚠️ +0.09
/ avg req/sec	1299.13	1241.5	⚠️ -57.63
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.268	1.178	-0.09
/error-in-render avg req/sec	1972.04	2122.46	+150.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bc293cf..9b2c.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
buildDuration	11.2s	11.5s	⚠️ +270ms
nodeModulesSize	82.7 MB	82.7 MB	-85 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bc293cf..9b2c.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js remove-import-type	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: de75c4d

ijjk added 2 commits December 21, 2020 20:55

Remove import type syntax

896040b

Merge remote-tracking branch 'upstream/canary' into remove-import-type

a51b75d

ijjk added the type: next label Dec 22, 2020

vercel bot temporarily deployed to Preview December 22, 2020 03:00 Inactive

ijjk marked this pull request as ready for review December 22, 2020 03:28

ijjk requested review from lfades, Timer and timneutkens as code owners December 22, 2020 03:28

Timer approved these changes Dec 28, 2020

View reviewed changes

Merge branch 'canary' into remove-import-type

d9cd15d

vercel bot temporarily deployed to Preview December 28, 2020 18:21 Inactive

ijjk mentioned this pull request Dec 28, 2020

Update i18n test #20548

Merged

kodiakhq bot pushed a commit that referenced this pull request Dec 28, 2020

Update i18n test (#20548)

1de5d78

This tweaks the new i18n query history test to address intermittent failures in CI x-ref: #19197 (comment) x-ref: #19135 (comment) x-ref: #20379 (comment)

Merge branch 'canary' into remove-import-type

de75c4d

vercel bot temporarily deployed to Preview December 28, 2020 21:44 Inactive

kodiakhq bot merged commit c98db81 into vercel:canary Dec 28, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove import type syntax from core files #20379

Remove import type syntax from core files #20379

ijjk commented Dec 22, 2020

ijjk commented Dec 22, 2020

matamatanot commented Dec 22, 2020

timneutkens commented Dec 22, 2020

ijjk commented Dec 28, 2020 •

edited

ijjk commented Dec 28, 2020

ijjk commented Dec 28, 2020

Remove import type syntax from core files #20379

Remove import type syntax from core files #20379

Conversation

ijjk commented Dec 22, 2020

ijjk commented Dec 22, 2020

Stats from current PR

matamatanot commented Dec 22, 2020

timneutkens commented Dec 22, 2020

ijjk commented Dec 28, 2020 • edited

Failing test suites

ijjk commented Dec 28, 2020

Stats from current PR

ijjk commented Dec 28, 2020

Stats from current PR

ijjk commented Dec 28, 2020 •

edited