Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): skip disable & upgrade platform #20647

Merged
merged 3 commits into from
Dec 31, 2020
Merged

fix(overlay): skip disable & upgrade platform #20647

merged 3 commits into from
Dec 31, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Dec 31, 2020

This bundles ally.js into Next.js itself to upgrade a dependency they have pinned.

I tried every other major focus trap solution, even those used by some modal libraries, and they all failed.

ally.js is the only library that can do it correctly, so we're going to stick with it.

I also removed the maintain/disabled as we have a backdrop that would effectively result in the same. This reduces CPU strain.

Fixes #19893
Fixes #14369
Closes #14372

@Timer
fix(overlay): skip disable & upgrade platform
5a45257 
This bundles ally.js into Next.js itself to upgrade a dependency they have pinned.

I tried every other major focus trap solution, even those used by some modal libraries, and they all failed.

`ally.js` is the only library that can do it correctly, so we're going to stick with it.

I also removed the `maintain/disabled` as we have a overlay that would effectively result in the same. This reduces CPU strain.

---

Fixes vercel#19893
Fixes vercel#14369
Closes vercel#14372
@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 10.2s 10.6s ⚠️ +458ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.029 2.037 ⚠️ +0.01
/ avg req/sec 1231.99 1227.43 ⚠️ -4.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.282 ⚠️ +0.02
/error-in-render avg req/sec 1983.59 1950.58 ⚠️ -33.01
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 12.7s 12.4s -330ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 5a45257

@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 9.9s 10.3s ⚠️ +341ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.035 2.013 -0.02
/ avg req/sec 1228.41 1242.05 +13.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.263 1.229 -0.03
/error-in-render avg req/sec 1979.73 2033.6 +53.87
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 12.4s 12.3s -68ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: e8624d4

@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 10.5s 10.9s ⚠️ +405ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.365 2.261 -0.1
/ avg req/sec 1056.87 1105.77 +48.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.646 1.713 ⚠️ +0.07
/error-in-render avg req/sec 1518.56 1459.31 ⚠️ -59.25
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
buildDuration 12.9s 13.1s ⚠️ +227ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/ally.js-platform Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 7562f0a

@kodiakhq kodiakhq bot merged commit e4a7446 into vercel:canary Dec 31, 2020
@Timer Timer deleted the hotfix/ally.js-platform branch December 31, 2020 19:09
@lachlanjc lachlanjc mentioned this pull request Jan 1, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-dev-overlay causes 100% CPU Swap out ally.js for focus-trap-react
2 participants
@Timer @ijjk