-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlay): skip disable & upgrade platform #20647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bundles ally.js into Next.js itself to upgrade a dependency they have pinned. I tried every other major focus trap solution, even those used by some modal libraries, and they all failed. `ally.js` is the only library that can do it correctly, so we're going to stick with it. I also removed the `maintain/disabled` as we have a overlay that would effectively result in the same. This reduces CPU strain. --- Fixes vercel#19893 Fixes vercel#14369 Closes vercel#14372
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.029 | 2.037 | |
/ avg req/sec | 1231.99 | 1227.43 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.26 | 1.282 | |
/error-in-render avg req/sec | 1983.59 | 1950.58 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
index.html gzip | 617 B | 617 B | ✓ |
link.html gzip | 622 B | 622 B | ✓ |
withRouter.html gzip | 610 B | 610 B | ✓ |
Overall change | 1.85 kB | 1.85 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
buildDuration | 12.7s | 12.4s | -330ms |
nodeModulesSize | 83 MB | 83 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.17 MB | 5.17 MB | ✓ |
ijjk
approved these changes
Dec 31, 2020
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
buildDuration | 9.9s | 10.3s | |
nodeModulesSize | 83 MB | 83 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.035 | 2.013 | -0.02 |
/ avg req/sec | 1228.41 | 1242.05 | +13.64 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.263 | 1.229 | -0.03 |
/error-in-render avg req/sec | 1979.73 | 2033.6 | +53.87 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
index.html gzip | 617 B | 617 B | ✓ |
link.html gzip | 622 B | 622 B | ✓ |
withRouter.html gzip | 610 B | 610 B | ✓ |
Overall change | 1.85 kB | 1.85 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
buildDuration | 12.4s | 12.3s | -68ms |
nodeModulesSize | 83 MB | 83 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.17 MB | 5.17 MB | ✓ |
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.365 | 2.261 | -0.1 |
/ avg req/sec | 1056.87 | 1105.77 | +48.9 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.646 | 1.713 | |
/error-in-render avg req/sec | 1518.56 | 1459.31 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
index.html gzip | 617 B | 617 B | ✓ |
link.html gzip | 622 B | 622 B | ✓ |
withRouter.html gzip | 610 B | 610 B | ✓ |
Overall change | 1.85 kB | 1.85 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
buildDuration | 12.9s | 13.1s | |
nodeModulesSize | 83 MB | 83 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
677f882d2ed8..2428.js gzip | 12.9 kB | 12.9 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-212f85f..f23b.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-7193..1446.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.2 kB | 59.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
polyfills-67..b7d1.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_app-6220e08..9a40.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-4b0b5..2c91.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-5f309a..7282.js gzip | 887 B | 887 B | ✓ |
index-57f580..c562.js gzip | 227 B | 227 B | ✓ |
link-b862cd7..dba8.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bd82.js gzip | 303 B | 303 B | ✓ |
withRouter-2..e384.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.08 kB | 8.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | Timer/next.js hotfix/ally.js-platform | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.17 MB | 5.17 MB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundles ally.js into Next.js itself to upgrade a dependency they have pinned.
I tried every other major focus trap solution, even those used by some modal libraries, and they all failed.
ally.js
is the only library that can do it correctly, so we're going to stick with it.I also removed the
maintain/disabled
as we have a backdrop that would effectively result in the same. This reduces CPU strain.Fixes #19893
Fixes #14369
Closes #14372