Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use autoprefixer instead of postcss-preset-env #21215

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Use autoprefixer instead of postcss-preset-env #21215

merged 2 commits into from
Jan 22, 2021

Conversation

giraffesyo
Copy link
Contributor

@giraffesyo giraffesyo commented Jan 15, 2021 •
edited

I realized while looking over this that the autoprefixer plugin isn't being used by postcss because it's not included in the postcss.config.js. Additionally, since postcss-preset-env doesn't support PostCSS 8 yet, and it includes PostCSS 7 as a dependency, I've removed that package.

There is an open issue to add PostCSS 8 support to postcss-preset-env here. @kripod's comments on my other PR #20956 are what prompted me to check this out.

On a side note, it looks like all the CMS examples use Tailwind CSS v1 still, so that's something someone (possibly myself) could tackle later.

@ijjk ijjk added the examples Issue/PR related to examples label Jan 15, 2021
@giraffesyo giraffesyo changed the title Use autoprefixer instead postcss-preset-env Use autoprefixer instead of postcss-preset-env Jan 15, 2021
@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 10.3s 10.1s -204ms
nodeModulesSize 77.5 MB 77.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary giraffesyo/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.992 2.005 ⚠️ +0.01
/ avg req/sec 1255.22 1246.64 ⚠️ -8.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.243 1.255 ⚠️ +0.01
/error-in-render avg req/sec 2011.2 1992.41 ⚠️ -18.79
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-712e20f..aa05.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary giraffesyo/next.js canary Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 12.1s 11.8s -237ms
nodeModulesSize 77.5 MB 77.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-712e20f..aa05.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary giraffesyo/next.js canary Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 7288256

@ijjk
Copy link
Member

ijjk commented Jan 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 8.3s 8.2s -117ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary giraffesyo/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.616 1.616 ✓
/ avg req/sec 1547.19 1547.13 ⚠️ -0.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.041 1.061 ⚠️ +0.02
/error-in-render avg req/sec 2402.45 2357.07 ⚠️ -45.38
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary giraffesyo/next.js canary Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 9.9s 9.5s -403ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary giraffesyo/next.js canary Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 9.8s 9.6s -211ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary giraffesyo/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.602 1.642 ⚠️ +0.04
/ avg req/sec 1560.21 1522.93 ⚠️ -37.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.007 1.062 ⚠️ +0.06
/error-in-render avg req/sec 2481.85 2354.06 ⚠️ -127.79
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
597-168f5a87..2380.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary giraffesyo/next.js canary Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "MFDRGQWjI_2w15SQaqeqr",
+        "buildId": "K0jepfy3zEk_6y3l7Iicf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_buildManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_ssgManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "MFDRGQWjI_2w15SQaqeqr",
+        "buildId": "K0jepfy3zEk_6y3l7Iicf",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_buildManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_ssgManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "MFDRGQWjI_2w15SQaqeqr",
+        "buildId": "K0jepfy3zEk_6y3l7Iicf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_buildManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/MFDRGQWjI_2w15SQaqeqr/_ssgManifest.js"
+      src="/_next/static/K0jepfy3zEk_6y3l7Iicf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 4ad561a

@kodiakhq kodiakhq bot merged commit ded6e24 into vercel:canary Jan 22, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giraffesyo @ijjk @Timer