Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generating static 500 status page #22139

Merged
merged 12 commits into from
Feb 22, 2021
Merged

Add generating static 500 status page #22139

merged 12 commits into from
Feb 22, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 12, 2021

This adds generating a static 500 status page when a pages/500.js file is added similar to how we handle generating static 404 pages when pages/404.js is present. This allows showing a customized error page when a 500 error occurs in an optimal way.

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review February 12, 2021 22:27
Timer
Timer requested changes Feb 15, 2021
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for when pages/_app.js has getInitialProps we still emit 500.html?

@ijjk ijjk requested a review from Timer February 15, 2021 15:34
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Feb 15, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 11.4s 11.2s -120ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +4.8 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.062 2.054 -0.01
/ avg req/sec 1212.2 1217.04 +4.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.296 1.283 -0.01
/error-in-render avg req/sec 1928.89 1949.25 +20.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..5cb0.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 13.7s 13.5s -241ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +4.8 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..5cb0.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
_error.js 1.01 MB 1.01 MB ⚠️ +368 B
404.html 2.67 kB 2.67 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ⚠️ +368 B
link.js 1.06 MB 1.06 MB ⚠️ +368 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +368 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +368 B
500.html N/A 2.65 kB N/A
Overall change 5.2 MB 5.21 MB ⚠️ +4.49 kB
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 13.3s 13.6s ⚠️ +260ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +4.8 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.077 2.051 -0.03
/ avg req/sec 1203.5 1218.92 +15.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.254 1.27 ⚠️ +0.02
/error-in-render avg req/sec 1994.31 1969.2 ⚠️ -25.11
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
597-d08f5fe5..d690.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-9e190..f9d6.js gzip 3.38 kB 3.38 kB ✓
amp-7fd79cc4..99ee.js gzip 538 B 538 B ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-7cc9e62..ef27.js gzip 1.66 kB 1.66 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.59 kB 8.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "pjR0HpVeJyD72Yxe16Ej0",
+        "buildId": "87HNMM_eqLzxWL8F7Mqkx",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_buildManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_ssgManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "pjR0HpVeJyD72Yxe16Ej0",
+        "buildId": "87HNMM_eqLzxWL8F7Mqkx",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_buildManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_ssgManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "pjR0HpVeJyD72Yxe16Ej0",
+        "buildId": "87HNMM_eqLzxWL8F7Mqkx",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_buildManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pjR0HpVeJyD72Yxe16Ej0/_ssgManifest.js"
+      src="/_next/static/87HNMM_eqLzxWL8F7Mqkx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c4e928b

Timer
Timer previously approved these changes Feb 19, 2021
View reviewed changes
@kodiakhq kodiakhq bot requested a review from divmain as a code owner February 19, 2021 17:51
@ijjk
Copy link
Member Author

ijjk commented Feb 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 9.7s 9.6s -58ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +4.8 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.753 1.827 ⚠️ +0.07
/ avg req/sec 1425.78 1368.48 ⚠️ -57.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.119 1.113 -0.01
/error-in-render avg req/sec 2233.99 2246.39 +12.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 11.3s 11.4s ⚠️ +64ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +4.8 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
_error.js 1.01 MB 1.01 MB ⚠️ +368 B
404.html 2.67 kB 2.67 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ⚠️ +368 B
link.js 1.06 MB 1.06 MB ⚠️ +368 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +368 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +368 B
500.html N/A 2.65 kB N/A
Overall change 5.2 MB 5.21 MB ⚠️ +4.49 kB
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 11.2s 11.3s ⚠️ +76ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +4.8 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.761 1.75 -0.01
/ avg req/sec 1420.04 1428.62 +8.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.114 1.104 -0.01
/error-in-render avg req/sec 2243.3 2265.26 +21.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
597-dc8125e2..ef24.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60 kB 60 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "fq5TesQI1vyjbF-T2uNOV",
+        "buildId": "38lt5YYGoI3brJwFV0tBr",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_buildManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_ssgManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "fq5TesQI1vyjbF-T2uNOV",
+        "buildId": "38lt5YYGoI3brJwFV0tBr",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_buildManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_ssgManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "fq5TesQI1vyjbF-T2uNOV",
+        "buildId": "38lt5YYGoI3brJwFV0tBr",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_buildManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fq5TesQI1vyjbF-T2uNOV/_ssgManifest.js"
+      src="/_next/static/38lt5YYGoI3brJwFV0tBr/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: e1e4e91

@ijjk ijjk requested a review from Timer February 19, 2021 21:42
@ijjk
Copy link
Member Author

ijjk commented Feb 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 11.2s 11.5s ⚠️ +310ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +5.63 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.084 2.091 ⚠️ +0.01
/ avg req/sec 1199.66 1195.51 ⚠️ -4.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.326 1.23 -0.1
/error-in-render avg req/sec 1885.61 2033.09 +147.48
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 13.7s 13.5s -240ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +5.63 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
_error.js 1.01 MB 1.01 MB ⚠️ +368 B
404.html 2.67 kB 2.67 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ⚠️ +368 B
link.js 1.06 MB 1.06 MB ⚠️ +368 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +368 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +368 B
500.html N/A 2.65 kB N/A
Overall change 5.2 MB 5.21 MB ⚠️ +4.49 kB
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
buildDuration 13.3s 13.3s -29ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +5.63 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/static-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.054 2.036 -0.02
/ avg req/sec 1217.42 1227.82 +10.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.259 1.3 ⚠️ +0.04
/error-in-render avg req/sec 1986.42 1923.74 ⚠️ -62.68
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/static-error Change
597-dc8125e2..ef24.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60 kB 60 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/static-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/static-error Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/static-error Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/static-error Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "kHRGuMjicWR9XXMTKrFMY",
+        "buildId": "3YnIQTxBvfIGPGznRQ1Jz",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_buildManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_ssgManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "kHRGuMjicWR9XXMTKrFMY",
+        "buildId": "3YnIQTxBvfIGPGznRQ1Jz",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_buildManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_ssgManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "kHRGuMjicWR9XXMTKrFMY",
+        "buildId": "3YnIQTxBvfIGPGznRQ1Jz",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_buildManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHRGuMjicWR9XXMTKrFMY/_ssgManifest.js"
+      src="/_next/static/3YnIQTxBvfIGPGznRQ1Jz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f8faf2e

This was referenced Mar 8, 2021
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
@ijjk ijjk mentioned this pull request Mar 8, 2021
Merged
@piotrrussw piotrrussw mentioned this pull request Mar 9, 2021
Closed
This was referenced Mar 11, 2021
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
nicholaschiang added a commit to tutorbookapp/tutorbook that referenced this pull request Mar 16, 2021
@nicholaschiang
fix(pages/500): add custom static 500 error page
78fd420 
Addresses the changes made by vercel/next.js#22139 by adding another
custom static 500 page (exactly the same as the custom 404 page but for
server-side errors).
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@divmain divmain Awaiting requested review from divmain

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @nicholaschiang @Timer