Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to setInterval #22357

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Fix call to setInterval #22357

merged 3 commits into from
Apr 19, 2021

Conversation

SystemDisc
Copy link
Contributor

No description provided.

@ijjk ijjk added the examples Issue/PR related to examples label Feb 20, 2021
@ijjk
Copy link
Member

ijjk commented Mar 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 11.7s 11.7s ⚠️ +4ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.048 2.005 -0.04
/ avg req/sec 1220.47 1246.71 +26.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.208 1.195 -0.01
/error-in-render avg req/sec 2069.04 2092.57 +23.53
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 13.2s 13.3s ⚠️ +135ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary elitan/next.js patch-1 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 13.4s 13.3s -139ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.973 1.969 0
/ avg req/sec 1266.95 1269.89 +2.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.174 1.254 ⚠️ +0.08
/error-in-render avg req/sec 2129.9 1993.56 ⚠️ -136.34
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "hkQBcfhHGQWSumh5nREkt",
+        "buildId": "6gu4VRQijWKTXoGoQGgcQ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_buildManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_ssgManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "hkQBcfhHGQWSumh5nREkt",
+        "buildId": "6gu4VRQijWKTXoGoQGgcQ",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_buildManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_ssgManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "hkQBcfhHGQWSumh5nREkt",
+        "buildId": "6gu4VRQijWKTXoGoQGgcQ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_buildManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hkQBcfhHGQWSumh5nREkt/_ssgManifest.js"
+      src="/_next/static/6gu4VRQijWKTXoGoQGgcQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 618251f

timneutkens
timneutkens previously approved these changes Mar 23, 2021
View reviewed changes
@Timer Timer changed the base branch from master to canary March 23, 2021 16:31
@Timer Timer dismissed timneutkens’s stale review March 23, 2021 16:31

The base branch was changed.

@kodiakhq kodiakhq bot merged commit 02f38c5 into vercel:canary Apr 19, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@SystemDisc @SokratisVidros
Fix call to setInterval (vercel#22357)
4c77f03
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens left review comments

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@divmain divmain Awaiting requested review from divmain

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SystemDisc @ijjk @Timer @timneutkens @leerob