Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade webpack 5 version #22737

Merged
merged 2 commits into from
Mar 3, 2021
Merged

chore: upgrade webpack 5 version #22737

merged 2 commits into from
Mar 3, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Mar 3, 2021

No description provided.

@ijjk
Copy link
Member

ijjk commented Mar 3, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 12.1s 12.1s -7ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.153 2.117 -0.04
/ avg req/sec 1161.27 1180.75 +19.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.355 1.334 -0.02
/error-in-render avg req/sec 1844.85 1874.15 +29.3
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 14.2s 14.2s ⚠️ +13ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 14.1s 14.1s ⚠️ +66ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.098 2.078 -0.02
/ avg req/sec 1191.65 1202.92 +11.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.364 1.341 -0.02
/error-in-render avg req/sec 1832.64 1864.54 +31.9
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "hNdNmU2F6FE0pOJW0KeSY",
+        "buildId": "ytjBa8_C8tCVGljOsoY1Z",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_buildManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_ssgManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "hNdNmU2F6FE0pOJW0KeSY",
+        "buildId": "ytjBa8_C8tCVGljOsoY1Z",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_buildManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_ssgManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "hNdNmU2F6FE0pOJW0KeSY",
+        "buildId": "ytjBa8_C8tCVGljOsoY1Z",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_buildManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hNdNmU2F6FE0pOJW0KeSY/_ssgManifest.js"
+      src="/_next/static/ytjBa8_C8tCVGljOsoY1Z/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f9e1bb8

@ijjk ijjk added the type: next label Mar 3, 2021
@ijjk
Copy link
Member

ijjk commented Mar 3, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 9.8s 9.8s -43ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.664 1.79 ⚠️ +0.13
/ avg req/sec 1502.49 1396.63 ⚠️ -105.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.064 1.052 -0.01
/error-in-render avg req/sec 2350.59 2376.04 +25.45
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 11.2s 11.5s ⚠️ +283ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
buildDuration 11.2s 11.2s ⚠️ +60ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +4.08 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.682 1.674 -0.01
/ avg req/sec 1486.46 1493.28 +6.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.037 1.009 -0.03
/error-in-render avg req/sec 2411.82 2477.12 +65.3
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/upgrade-webpack Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Yu_Ys8XYDLz5Z_REQ6kVl",
+        "buildId": "fZ3Ntrjdt6nu5a8_apMRi",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_buildManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_ssgManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Yu_Ys8XYDLz5Z_REQ6kVl",
+        "buildId": "fZ3Ntrjdt6nu5a8_apMRi",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_buildManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_ssgManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Yu_Ys8XYDLz5Z_REQ6kVl",
+        "buildId": "fZ3Ntrjdt6nu5a8_apMRi",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_buildManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yu_Ys8XYDLz5Z_REQ6kVl/_ssgManifest.js"
+      src="/_next/static/fZ3Ntrjdt6nu5a8_apMRi/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c1ae1c0

@kodiakhq kodiakhq bot merged commit 61dae38 into vercel:canary Mar 3, 2021
@Timer Timer deleted the feat/upgrade-webpack branch March 3, 2021 19:53
This was referenced Mar 5, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
This was referenced Mar 8, 2021
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@bradlc bradlc mentioned this pull request Mar 16, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk