Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure /404 is not exported during build un-necessarily #22825

Merged
merged 2 commits into from Mar 8, 2021
Merged

Ensure /404 is not exported during build un-necessarily #22825

merged 2 commits into from Mar 8, 2021
+11 −4

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 6, 2021

This ensures we don't export /404 during the automatic static optimization during build when the /404 isn't static and won't be used/copied to the final output.

x-ref: #22815

@ijjk ijjk added the type: next label Mar 6, 2021
@ijjk
Copy link
Member Author

ijjk commented Mar 6, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 11.7s 11.9s ⚠️ +290ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.984 2.099 ⚠️ +0.12
/ avg req/sec 1260.31 1190.84 ⚠️ -69.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.271 1.245 -0.03
/error-in-render avg req/sec 1967.44 2008.31 +40.87
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/build-404-export Change
index.html gzip 615 B 615 B ✓
link.html gzip 623 B 623 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 13.7s 13.7s ⚠️ +73ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/build-404-export Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 13.8s 13.5s -255ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/build-404-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.133 1.996 -0.14
/ avg req/sec 1172.09 1252.36 +80.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.272 1.223 -0.05
/error-in-render avg req/sec 1964.65 2043.52 +78.87
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/build-404-export Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "5dd1CkT81ObXbbKPskxH1",
+        "buildId": "HpdMgsL3Oh3y-lQP2i2DA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_buildManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_ssgManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "5dd1CkT81ObXbbKPskxH1",
+        "buildId": "HpdMgsL3Oh3y-lQP2i2DA",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_buildManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_ssgManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "5dd1CkT81ObXbbKPskxH1",
+        "buildId": "HpdMgsL3Oh3y-lQP2i2DA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_buildManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5dd1CkT81ObXbbKPskxH1/_ssgManifest.js"
+      src="/_next/static/HpdMgsL3Oh3y-lQP2i2DA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 26d0a5e

@ijjk ijjk marked this pull request as ready for review March 6, 2021 19:49
@ijjk
Copy link
Member Author

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 11.8s 11.6s -134ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.984 2 ⚠️ +0.02
/ avg req/sec 1259.78 1249.86 ⚠️ -9.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.254 1.256 0
/error-in-render avg req/sec 1993.31 1990.03 ⚠️ -3.28
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/build-404-export Change
index.html gzip 615 B 615 B ✓
link.html gzip 623 B 623 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 13.8s 13.8s -29ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/build-404-export Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
buildDuration 13.5s 13.5s ⚠️ +52ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +99 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/build-404-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.996 1.979 -0.02
/ avg req/sec 1252.68 1263.04 +10.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.23 1.265 ⚠️ +0.03
/error-in-render avg req/sec 2033.15 1976.32 ⚠️ -56.83
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/build-404-export Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/build-404-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/build-404-export Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/build-404-export Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/build-404-export Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "pBJ8pOEMaV9x7AyRQIYu_",
+        "buildId": "OiXoNeDATZ9jESFOW5uxZ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_buildManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_ssgManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "pBJ8pOEMaV9x7AyRQIYu_",
+        "buildId": "OiXoNeDATZ9jESFOW5uxZ",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_buildManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_ssgManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "pBJ8pOEMaV9x7AyRQIYu_",
+        "buildId": "OiXoNeDATZ9jESFOW5uxZ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_buildManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/pBJ8pOEMaV9x7AyRQIYu_/_ssgManifest.js"
+      src="/_next/static/OiXoNeDATZ9jESFOW5uxZ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 930b252

@kodiakhq kodiakhq bot merged commit cdf8f9a into vercel:canary Mar 8, 2021
@ijjk ijjk deleted the update/build-404-export branch March 8, 2021 14:55
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens