Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add info about fallback to prerender-error #22828

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

geritol
Copy link
Contributor

@geritol geritol commented Mar 6, 2021

No description provided.

@@ -9,3 +9,4 @@ While prerendering a page an error occurred. This can occur for many reasons fro
- Make sure to move any non-pages out of the `pages` folder
- Check for any code that assumes a prop is available even when it might not be. e.g., have default data for all dynamic pages' props.
- Check for any out of date modules that you might be relying on
- Make sure your component handles `fallback` if it is enabled in `getStaticPaths`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a link to the relevant documentation for fallback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens added link to fallback docs

timneutkens
timneutkens previously approved these changes Mar 9, 2021
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

leerob
leerob previously approved these changes Apr 20, 2021
@leerob
Copy link
Member

leerob commented Apr 20, 2021

I'm not sure why 6 reviews are required here 🤔

@timneutkens timneutkens changed the base branch from master to canary April 20, 2021 08:07
@timneutkens timneutkens dismissed stale reviews from leerob and themself April 20, 2021 08:07

The base branch was changed.

@timneutkens
Copy link
Member

I'm not sure why 6 reviews are required here 🤔

@leerob this PR was opened against the wrong branch (not canary) hence why it does not allow merging. I've updated the base branch.

@kodiakhq kodiakhq bot merged commit 997b37a into vercel:canary Apr 20, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants