Fixed bug where styled-jsx examples don't work because of a wrong plugin #23414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1ck0
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
M1ck0
changed the title
M1ck0
changed the title
theoludwig
reviewed
Mar 26, 2021
| @@ -13,8 +13,7 @@ | |||
| "next": "^10.0.0", | |||
| "sass": "^1.32.4", | |||
| "react": "17.0.1", | |||
| "react-dom": "17.0.1", | |||
| "styled-jsx-plugin-sass": "^1.0.0" | |||
There was a problem hiding this comment.
In fact, we still need to have @styled-jsx/plugin-sass in devDependencies and sass should be in devDependencies.
There was a problem hiding this comment.
Actually, we don't need @styled-jsx/plugin-sass because styled-jsx is shipped with NextJS and it works out of the box.
And yeah, you are right. I will put sass in dev dependencies now.
There was a problem hiding this comment.
Yes styled-jsx is there out of the box in next but it is not the case for this plugin, to use it, you need to install it on your own.
There was a problem hiding this comment.
Actually, you are right. My bad. I added it now.
moved `sass` in devDependencies
added `sass` in devDependencies
added `@styled-jsx/plugin-sass` to devDependencies
added `@styled-jsx/plugin-sass` to devDependencies
theoludwig
approved these changes
Mar 26, 2021
leerob
approved these changes
Apr 3, 2021
ijjk
approved these changes
Apr 19, 2021
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
…gin (vercel#23414) ## Bug Fixes vercel#23293. Problem was that `styled-jsx-plugin-sass` was used instead of `@styled-jsx/plugin-sass` so it didn't work. You can refer to the issue that is linked for more info.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #23293.
Problem was that
styled-jsx-plugin-sasswas used instead of@styled-jsx/plugin-sassso it didn't work.You can refer to the issue that is linked for more info.