Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no-op rewrite matches dynamic route with i18n correctly #23860

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Ensure no-op rewrite matches dynamic route with i18n correctly #23860

merged 5 commits into from
Apr 12, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 9, 2021

This ensures we match dynamic routes correctly when applying check: true behavior with i18n so that no-op rewrites match dynamic routes correctly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23854

@ijjk ijjk added the type: next label Apr 9, 2021
@ijjk
Copy link
Member Author

ijjk commented Apr 9, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
buildDuration 14.2s 13.4s -804ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +224 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.955 2.896 -0.06
/ avg req/sec 846.16 863.17 +17.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.843 1.789 -0.05
/error-in-render avg req/sec 1356.63 1397.61 +40.98
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
buildDuration 15.9s 15.8s -147ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +224 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7.01 MB 7.01 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
buildDuration 16.7s 16.5s -164ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +224 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.965 2.925 -0.04
/ avg req/sec 843.3 854.77 +11.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.842 1.73 -0.11
/error-in-render avg req/sec 1357.01 1445.4 +88.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9356d64c..e712.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/check-true-i18n Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "jBgcwErdPG6uYGMDLocmX",
+        "buildId": "frMccXf1vJ3-v4OAPhiyH",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_buildManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_ssgManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "jBgcwErdPG6uYGMDLocmX",
+        "buildId": "frMccXf1vJ3-v4OAPhiyH",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_buildManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_ssgManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "jBgcwErdPG6uYGMDLocmX",
+        "buildId": "frMccXf1vJ3-v4OAPhiyH",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_buildManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/jBgcwErdPG6uYGMDLocmX/_ssgManifest.js"
+      src="/_next/static/frMccXf1vJ3-v4OAPhiyH/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 9c6e692

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review April 10, 2021 17:27
@kodiakhq kodiakhq bot merged commit f02363e into vercel:canary Apr 12, 2021
@ijjk ijjk deleted the fix/check-true-i18n branch April 12, 2021 16:07
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Ensure no-op rewrite matches dynamic route with i18n correctly (verce…
9ef15ca 
…l#23860)

This ensures we match dynamic routes correctly when applying `check: true` behavior with i18n so that no-op rewrites match dynamic routes correctly. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

Fixes: vercel#23854
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic routing does not work with rewrites in dev environment
2 participants
@ijjk @timneutkens