Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types of next-webdriver #23995

Merged
merged 2 commits into from
Apr 20, 2021
Merged

fix types of next-webdriver #23995

merged 2 commits into from
Apr 20, 2021

Conversation

flybayer
Copy link
Contributor

This does not touch any next.js code. This improves the integration test setup by properly typing next-webdriver.

@ijjk
Copy link
Member

ijjk commented Apr 20, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary flybayer/next.js webdriver-types Change
buildDuration 14.8s 15s ⚠️ +117ms
buildDurationCached 4.9s 4.6s -272ms
nodeModulesSize 46.6 MB 46.6 MB
Page Load Tests Overall increase ✓
vercel/next.js canary flybayer/next.js webdriver-types Change
/ failed reqs 0 0
/ total time (seconds) 2.525 2.529 0
/ avg req/sec 990.17 988.34 ⚠️ -1.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.3 1.27 -0.03
/error-in-render avg req/sec 1922.46 1968.39 +45.93
Client Bundles (main, webpack, commons)
vercel/next.js canary flybayer/next.js webdriver-types Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.12 kB 7.12 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary flybayer/next.js webdriver-types Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary flybayer/next.js webdriver-types Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary flybayer/next.js webdriver-types Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary flybayer/next.js webdriver-types Change
index.html gzip 611 B 611 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General
vercel/next.js canary flybayer/next.js webdriver-types Change
buildDuration 18.5s 18.4s -82ms
buildDurationCached 7.1s 7s -46ms
nodeModulesSize 46.6 MB 46.6 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary flybayer/next.js webdriver-types Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.12 kB 7.12 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary flybayer/next.js webdriver-types Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary flybayer/next.js webdriver-types Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary flybayer/next.js webdriver-types Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles
vercel/next.js canary flybayer/next.js webdriver-types Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
css.html 2.13 kB 2.13 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.15 MB 7.15 MB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary flybayer/next.js webdriver-types Change
buildDuration 12.4s 12.6s ⚠️ +178ms
buildDurationCached 5.3s 5.1s -196ms
nodeModulesSize 46.6 MB 46.6 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary flybayer/next.js webdriver-types Change
/ failed reqs 0 0
/ total time (seconds) 2.473 2.541 ⚠️ +0.07
/ avg req/sec 1010.98 983.69 ⚠️ -27.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.269 1.305 ⚠️ +0.04
/error-in-render avg req/sec 1970.06 1915.45 ⚠️ -54.61
Client Bundles (main, webpack, commons)
vercel/next.js canary flybayer/next.js webdriver-types Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.2 kB 7.2 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary flybayer/next.js webdriver-types Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary flybayer/next.js webdriver-types Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.36 kB 9.36 kB
Client Build Manifests
vercel/next.js canary flybayer/next.js webdriver-types Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary flybayer/next.js webdriver-types Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: ed3a8b4

@kodiakhq kodiakhq bot merged commit 8ccfff1 into vercel:canary Apr 20, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 21, 2021
This does not touch any next.js code. This improves the integration test setup by properly typing next-webdriver.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants