Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel Turbo Loader, Part 2 #24078

Merged
merged 11 commits into from
Apr 20, 2021
Merged

Babel Turbo Loader, Part 2 #24078

merged 11 commits into from
Apr 20, 2021

Conversation

divmain
Copy link
Contributor

@divmain divmain commented Apr 14, 2021 •
edited

This PR addresses the potential for memory leakage with the previous caching scheme; it should also be more efficient, resulting in fewer instances where a fresh Babel config must be generated. Documentation has been added, and overrides have been removed in favor of conditional plugins for consistency.

This approach is easier to break, in that CharacteristicsGermaneToCaching must be correct for all cases. However, it means that <= 8 configs will need to be generated within the context of a single thread, and the config-caching is about as fast as we can get it.

@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 12.5s 12.4s -108ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.264 2.246 -0.02
/ avg req/sec 1104.02 1113.11 +9.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.205 1.186 -0.02
/error-in-render avg req/sec 2074.25 2108.43 +34.18
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 15.5s 15.4s -149ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +7.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB -2 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB -2 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 13s 12.3s -713ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.269 2.162 -0.11
/ avg req/sec 1101.57 1156.13 +54.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.195 1.109 -0.09
/error-in-render avg req/sec 2092.32 2255.18 +162.86
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "2uMoAX8lx8AALwvcHAAfB",
+        "buildId": "mTfoQcbfleqvlk57hBj3I",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_buildManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_ssgManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "2uMoAX8lx8AALwvcHAAfB",
+        "buildId": "mTfoQcbfleqvlk57hBj3I",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_buildManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_ssgManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "2uMoAX8lx8AALwvcHAAfB",
+        "buildId": "mTfoQcbfleqvlk57hBj3I",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_buildManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2uMoAX8lx8AALwvcHAAfB/_ssgManifest.js"
+      src="/_next/static/mTfoQcbfleqvlk57hBj3I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 9d8a492

@vercel vercel deleted a comment from ijjk Apr 14, 2021
@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Failing test suites

Commit: 9d8a492

test/integration/styled-jsx-plugin/test/index.test.js

  • styled-jsx using in node_modules > production mode > should serve a page correctly
Expand output

● styled-jsx using in node_modules › production mode › should serve a page correctly

FetchError: request to http://localhost:38663/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 14.3s 14.6s ⚠️ +263ms
buildDurationCached 4.8s 5s ⚠️ +205ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.46 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.477 2.501 ⚠️ +0.02
/ avg req/sec 1009.11 999.48 ⚠️ -9.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.258 1.295 ⚠️ +0.04
/error-in-render avg req/sec 1987.95 1930.21 ⚠️ -57.74
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-ee4f51be..fb74.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 17.9s 18.1s ⚠️ +211ms
buildDurationCached 6.8s 6.9s ⚠️ +98ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.46 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-ee4f51be..fb74.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_error.js 1.39 MB 1.39 MB ⚠️ +2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 14.5s 14.4s -23ms
buildDurationCached 4.9s 4.5s -366ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.46 kB
Page Load Tests Overall increase ✓
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.532 2.504 -0.03
/ avg req/sec 987.36 998.29 +10.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.266 1.216 -0.05
/error-in-render avg req/sec 1974.06 2056.34 +82.28
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-ee4f51be..fb74.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "oXuOeZipcWVDsVNwojV3_",
+        "buildId": "zRJ9yLmTBMkA8l0kRT1gK",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_buildManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_ssgManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "oXuOeZipcWVDsVNwojV3_",
+        "buildId": "zRJ9yLmTBMkA8l0kRT1gK",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_buildManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_ssgManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "oXuOeZipcWVDsVNwojV3_",
+        "buildId": "zRJ9yLmTBMkA8l0kRT1gK",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_buildManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/oXuOeZipcWVDsVNwojV3_/_ssgManifest.js"
+      src="/_next/static/zRJ9yLmTBMkA8l0kRT1gK/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8c1f4fb

@ijjk
Copy link
Member

ijjk commented Apr 20, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 17.7s 17.3s -357ms
buildDurationCached 5.7s 6.2s ⚠️ +504ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Page Load Tests Overall increase ✓
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.153 3.058 -0.1
/ avg req/sec 792.91 817.57 +24.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.849 1.787 -0.06
/error-in-render avg req/sec 1351.96 1399.21 +47.25
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-c0d3b055..b452.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 603 B 603 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 22.1s 22s -94ms
buildDurationCached 8s 8.2s ⚠️ +164ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-c0d3b055..b452.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 17.9s 17.9s -16ms
buildDurationCached 5.8s 5.6s -273ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.073 3.085 ⚠️ +0.01
/ avg req/sec 813.42 810.27 ⚠️ -3.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.723 1.869 ⚠️ +0.15
/error-in-render avg req/sec 1450.74 1337.61 ⚠️ -113.13
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-ce2d8ad2..a2d3.js gzip 13.3 kB 13.3 kB ✓
778-c0d3b055..b452.js gzip 7.08 kB 7.08 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
css-ba062d31..3e65.js gzip 363 B 363 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.4 kB 9.4 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 603 B 603 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "OSSA9NBj_Ykf6pq29mhmr",
+        "buildId": "9hhSqHS16mlcwORfEXY6N",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_buildManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_ssgManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "OSSA9NBj_Ykf6pq29mhmr",
+        "buildId": "9hhSqHS16mlcwORfEXY6N",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_buildManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_ssgManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "OSSA9NBj_Ykf6pq29mhmr",
+        "buildId": "9hhSqHS16mlcwORfEXY6N",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_buildManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/OSSA9NBj_Ykf6pq29mhmr/_ssgManifest.js"
+      src="/_next/static/9hhSqHS16mlcwORfEXY6N/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 462bd5d

@ijjk
Copy link
Member

ijjk commented Apr 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 15.5s 15.4s -48ms
buildDurationCached 5s 4.8s -248ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.7 2.854 ⚠️ +0.15
/ avg req/sec 926.09 876.09 ⚠️ -50
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.555 1.538 -0.02
/error-in-render avg req/sec 1608.13 1624.98 +16.85
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 603 B 603 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 19.6s 19.2s -421ms
buildDurationCached 7.1s 7.2s ⚠️ +108ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ⚠️ +2 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
buildDuration 12.8s 12.9s ⚠️ +77ms
buildDurationCached 5.4s 5.2s -216ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +7.73 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.672 2.725 ⚠️ +0.05
/ avg req/sec 935.7 917.34 ⚠️ -18.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.5 1.55 ⚠️ +0.05
/error-in-render avg req/sec 1666.36 1613.28 ⚠️ -53.08
Client Bundles (main, webpack, commons)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary divmain/next.js babel-loader-part-2 Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 91f9c16

@kodiakhq kodiakhq bot merged commit b2d8e15 into vercel:canary Apr 20, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@divmain @SokratisVidros
Babel Turbo Loader, Part 2 (vercel#24078)
e70e2cd 
This PR addresses the potential for memory leakage with the previous caching scheme; it should also be more efficient, resulting in fewer instances where a fresh Babel config must be generated.  Documentation has been added, and `overrides` have been removed in favor of conditional plugins for consistency.

This approach is easier to break, in that `CharacteristicsGermaneToCaching` must be correct for all cases.  However, it means that <= 8 configs will need to be generated within the context of a single thread, and the config-caching is about as fast as we can get it.
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@divmain @ijjk @timneutkens