Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to build command #24158

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Minor fix to build command #24158

merged 3 commits into from
Apr 19, 2021

Conversation

AntelaBrais
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue/PR related to examples label Apr 16, 2021
@leerob
Copy link
Member

leerob commented Apr 16, 2021

It should work either way, yeah?

@AntelaBrais
Copy link
Contributor Author

I tested it the way it was originally posted and it didn't work. After reading Docker's documentation I tried the command the way they'd posted and then it worked. In the official documentation, they have this example:
$ docker build -t vieux/apache:2.0 .
Also, the command structure they show is as follows: docker build [OPTIONS] PATH | URL | -.
Hope this helps 🙂

@kodiakhq kodiakhq bot merged commit fa13835 into vercel:canary Apr 19, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@AntelaBrais @SokratisVidros
Minor fix to build command (vercel#24158)
1f17db1 
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AntelaBrais @leerob @ijjk