Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure locale cookie does not error with similarly named cookie #24182

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Ensure locale cookie does not error with similarly named cookie #24182

merged 4 commits into from
Apr 20, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2021

This ensures we don't error when a cookie with a similar name to the NEXT_LOCALE cookie is present.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23787
Closes: #23788

@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 14.8s 14.8s -81ms
buildDurationCached 4.6s 4.5s -33ms
nodeModulesSize 46.2 MB 46.2 MB -180 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.704 2.62 -0.08
/ avg req/sec 924.42 954.36 +29.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.56 1.539 -0.02
/error-in-render avg req/sec 1602.59 1624.33 +21.74
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 18.7s 18.2s -511ms
buildDurationCached 6.6s 6.5s -97ms
nodeModulesSize 46.2 MB 46.2 MB -180 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_error.js 1.39 MB 1.39 MB -54 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -54 B
link.js 1.45 MB 1.45 MB -52 B
routerDirect.js 1.44 MB 1.44 MB -56 B
withRouter.js 1.44 MB 1.44 MB -54 B
Overall change 7.14 MB 7.14 MB -270 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 12.3s 12.2s -35ms
buildDurationCached 5s 5s -53ms
nodeModulesSize 46.2 MB 46.2 MB -180 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.684 2.614 -0.07
/ avg req/sec 931.38 956.55 +25.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.532 1.609 ⚠️ +0.08
/error-in-render avg req/sec 1632.33 1554.05 ⚠️ -78.28
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 44b4181

@ijjk ijjk marked this pull request as ready for review April 17, 2021 18:17
timneutkens
timneutkens requested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the is a merge conflict on this one

@ijjk
Merge remote-tracking branch 'upstream/canary' into fix/i18n-invalid-…
d46630e 
…cookie

# Conflicts:
#	test/integration/i18n-support/test/shared.js
@ijjk
Copy link
Member Author

ijjk commented Apr 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 13.6s 13.7s ⚠️ +94ms
buildDurationCached 4.3s 4.1s -106ms
nodeModulesSize 46.3 MB 46.3 MB -180 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.418 2.408 -0.01
/ avg req/sec 1033.84 1038.06 +4.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.279 1.238 -0.04
/error-in-render avg req/sec 1954 2019.27 +65.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 17.3s 16.6s -721ms
buildDurationCached 6.1s 6.2s ⚠️ +174ms
nodeModulesSize 46.3 MB 46.3 MB -180 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_error.js 1.39 MB 1.39 MB -54 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -54 B
link.js 1.45 MB 1.45 MB -54 B
routerDirect.js 1.44 MB 1.44 MB -54 B
withRouter.js 1.44 MB 1.44 MB -54 B
Overall change 7.15 MB 7.15 MB -270 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 11.7s 11.6s -19ms
buildDurationCached 4.7s 4.6s -118ms
nodeModulesSize 46.3 MB 46.3 MB -180 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.409 2.382 -0.03
/ avg req/sec 1037.84 1049.47 +11.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.289 1.269 -0.02
/error-in-render avg req/sec 1939.79 1970.26 +30.47
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 618 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: d46630e

@ijjk ijjk requested a review from timneutkens April 18, 2021 13:52
@ijjk
Copy link
Member Author

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 13.4s 15s ⚠️ +1.6s
buildDurationCached 4.7s 4.2s -466ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.302 2.386 ⚠️ +0.08
/ avg req/sec 1085.93 1047.56 ⚠️ -38.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.18 1.209 ⚠️ +0.03
/error-in-render avg req/sec 2118.33 2067.35 ⚠️ -50.98
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 16.8s 16.8s -49ms
buildDurationCached 6.5s 6.7s ⚠️ +160ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_error.js 1.39 MB 1.39 MB -54 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -54 B
link.js 1.45 MB 1.45 MB -54 B
routerDirect.js 1.44 MB 1.44 MB -54 B
withRouter.js 1.44 MB 1.44 MB -54 B
Overall change 7.15 MB 7.15 MB -270 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 12.6s 11.2s -1.3s
buildDurationCached 5.3s 4.8s -522ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.482 2.306 -0.18
/ avg req/sec 1007.07 1083.89 +76.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.282 1.179 -0.1
/error-in-render avg req/sec 1950.36 2120.55 +170.19
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 85bd3a4

@ijjk
Copy link
Member Author

ijjk commented Apr 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 14.8s 15.1s ⚠️ +298ms
buildDurationCached 4.9s 4.5s -347ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.647 2.711 ⚠️ +0.06
/ avg req/sec 944.44 922.28 ⚠️ -22.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.483 1.609 ⚠️ +0.13
/error-in-render avg req/sec 1685.56 1553.37 ⚠️ -132.19
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 603 B 603 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 18.1s 17.9s -222ms
buildDurationCached 6.6s 6.8s ⚠️ +194ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_error.js 1.39 MB 1.39 MB -54 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -54 B
link.js 1.45 MB 1.45 MB -54 B
routerDirect.js 1.44 MB 1.44 MB -54 B
withRouter.js 1.44 MB 1.44 MB -54 B
Overall change 7.15 MB 7.15 MB -270 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
buildDuration 12.6s 12.7s ⚠️ +110ms
buildDurationCached 5s 5.1s ⚠️ +102ms
nodeModulesSize 46.6 MB 46.6 MB -180 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.641 2.687 ⚠️ +0.05
/ avg req/sec 946.54 930.4 ⚠️ -16.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.539 1.609 ⚠️ +0.07
/error-in-render avg req/sec 1624.03 1553.92 ⚠️ -70.11
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-invalid-cookie Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 26db954

@kodiakhq kodiakhq bot merged commit e532c58 into vercel:canary Apr 20, 2021
@ijjk ijjk deleted the fix/i18n-invalid-cookie branch April 20, 2021 13:41
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Ensure locale cookie does not error with similarly named cookie (verc…
20e44ce 
…el#24182)

This ensures we don't error when a cookie with a similar name to the `NEXT_LOCALE` cookie is present. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

Fixes: vercel#23787
Closes: vercel#23788
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie locale detection is broken if cookie name is similar with NEXT_COOKIE
2 participants
@ijjk @timneutkens