Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack to 5.34 #24230

Merged
merged 2 commits into from
Apr 19, 2021
Merged

upgrade webpack to 5.34 #24230

merged 2 commits into from
Apr 19, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 19, 2021

No description provided.

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 11.7s 11.7s ⚠️ +58ms
buildDurationCached 3.6s 3.6s ⚠️ +15ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.073 2.039 -0.03
/ avg req/sec 1205.87 1226.38 +20.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.071 1.073 0
/error-in-render avg req/sec 2333.41 2329.99 ⚠️ -3.42
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 609 B 609 B
link.html gzip 614 B 614 B
withRouter.html gzip 604 B 604 B
Overall change 1.83 kB 1.83 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 14.6s 14.7s ⚠️ +65ms
buildDurationCached 5.3s 5.4s ⚠️ +43ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
_error.js 1.39 MB 1.39 MB -2 B
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.15 MB 7.15 MB -2 B

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 10.1s 10.3s ⚠️ +238ms
buildDurationCached 4.2s 4.2s -40ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.072 2.102 ⚠️ +0.03
/ avg req/sec 1206.32 1189.39 ⚠️ -16.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.102 1.14 ⚠️ +0.04
/error-in-render avg req/sec 2268.25 2192.29 ⚠️ -75.96
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.16 kB 7.16 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
hooks-HASH.js gzip 888 B 888 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
Overall change 8.89 kB 8.89 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 371 B 371 B
Overall change 371 B 371 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 7ef1e34

@sokra sokra marked this pull request as ready for review April 19, 2021 17:13
@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 15s 14.7s -210ms
buildDurationCached 4.3s 4.4s ⚠️ +35ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.643 2.631 -0.01
/ avg req/sec 945.8 950.16 +4.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.512 1.482 -0.03
/error-in-render avg req/sec 1653.61 1686.73 +33.12
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 609 B 609 B
link.html gzip 614 B 614 B
withRouter.html gzip 604 B 604 B
Overall change 1.83 kB 1.83 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 18.4s 18.1s -286ms
buildDurationCached 6.7s 6.4s -271ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB -2 B
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.15 MB 7.15 MB -2 B

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 12.1s 12.2s ⚠️ +95ms
buildDurationCached 4.9s 5.2s ⚠️ +272ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.683 2.672 -0.01
/ avg req/sec 931.89 935.6 +3.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.547 1.478 -0.07
/error-in-render avg req/sec 1615.52 1691.76 +76.24
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.16 kB 7.16 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
hooks-HASH.js gzip 888 B 888 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
Overall change 8.89 kB 8.89 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 371 B 371 B
Overall change 371 B 371 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 817994f

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 14.4s 14.3s -133ms
buildDurationCached 4.6s 3.7s -869ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.571 2.523 -0.05
/ avg req/sec 972.3 990.8 +18.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.406 1.428 ⚠️ +0.02
/error-in-render avg req/sec 1778.17 1750.99 ⚠️ -27.18
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 610 B 610 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 15.6s 15.3s -270ms
buildDurationCached 5.8s 5.7s -175ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.08 kB 7.08 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles
vercel/next.js canary vercel/next.js webpack/5.34 Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
css.html 2.13 kB 2.13 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.15 MB 7.15 MB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.34 Change
buildDuration 10.1s 11.1s ⚠️ +933ms
buildDurationCached 4.8s 5.2s ⚠️ +454ms
nodeModulesSize 46.3 MB 46.6 MB ⚠️ +345 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.34 Change
/ failed reqs 0 0
/ total time (seconds) 2.337 2.342 0
/ avg req/sec 1069.61 1067.49 ⚠️ -2.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.401 1.33 -0.07
/error-in-render avg req/sec 1784.49 1879.83 +95.34
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.34 Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.16 kB 7.16 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.34 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/5.34 Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.36 kB 9.36 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.34 Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.34 Change
index.html gzip 612 B 612 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: ffdcb48

@kodiakhq kodiakhq bot merged commit 155e34c into canary Apr 19, 2021
@kodiakhq kodiakhq bot deleted the webpack/5.34 branch April 19, 2021 18:18
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants