Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made template look correct in IE11 #24245

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Made template look correct in IE11 #24245

merged 3 commits into from
Apr 20, 2021

Conversation

Hanaffi
Copy link
Contributor

@Hanaffi Hanaffi commented Apr 19, 2021

Bug

Fixes #21324

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Apr 19, 2021
@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 16.6s 16.5s -113ms
buildDurationCached 5.3s 4.9s -443ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.859 2.843 -0.02
/ avg req/sec 874.56 879.41 +4.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.607 1.74 ⚠️ +0.13
/error-in-render avg req/sec 1555.32 1436.61 ⚠️ -118.71
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 20.2s 19.9s -349ms
buildDurationCached 7.4s 7.3s -126ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +4 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ⚠️ +2 B
Overall change 7.15 MB 7.15 MB ⚠️ +6 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 13.2s 13s -199ms
buildDurationCached 5.4s 5.4s -32ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.821 2.811 -0.01
/ avg req/sec 886.25 889.46 +3.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.571 1.617 ⚠️ +0.05
/error-in-render avg req/sec 1591.3 1546.08 ⚠️ -45.22
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: fc2d641

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 14.1s 14.1s -64ms
buildDurationCached 4.7s 4.3s -322ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.426 2.394 -0.03
/ avg req/sec 1030.34 1044.23 +13.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.269 1.246 -0.02
/error-in-render avg req/sec 1970.47 2005.65 +35.18
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 17.8s 17.9s ⚠️ +46ms
buildDurationCached 6.8s 6.7s -40ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ⚠️ +4 B
withRouter.js 1.44 MB 1.44 MB ⚠️ +2 B
Overall change 7.15 MB 7.15 MB ⚠️ +6 B
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 12.3s 12.2s -88ms
buildDurationCached 5.1s 5s -162ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.425 2.364 -0.06
/ avg req/sec 1030.81 1057.68 +26.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.277 1.277 ✓
/error-in-render avg req/sec 1957.11 1957.66 +0.55
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 8075326

leerob
leerob reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share an image showing it's fixed? 🙏

@leerob leerob mentioned this pull request Apr 20, 2021
Closed
@leerob
Copy link
Member

leerob commented Apr 20, 2021

I've closed two other PRs trying to accomplish this as well. Let's use this one 👍

@Hanaffi
Copy link
Contributor Author

Hanaffi commented Apr 20, 2021

@leerob Here is screenshot
Untitled

@Hanaffi Hanaffi requested a review from leerob April 20, 2021 10:01
leerob
leerob approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@ijjk
Copy link
Member

ijjk commented Apr 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 13s 13.1s ⚠️ +145ms
buildDurationCached 4.2s 4s -277ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.198 2.205 ⚠️ +0.01
/ avg req/sec 1137.43 1133.83 ⚠️ -3.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.118 1.12 0
/error-in-render avg req/sec 2235.48 2232.23 ⚠️ -3.25
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 16.3s 17s ⚠️ +707ms
buildDurationCached 6.6s 6.6s ⚠️ +14ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_error.js 1.39 MB 1.39 MB ⚠️ +2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary Hanaffi/next.js fixTemplate Change
buildDuration 12s 11.7s -368ms
buildDurationCached 4.9s 4.9s -50ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Hanaffi/next.js fixTemplate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.33 2.32 -0.01
/ avg req/sec 1073.01 1077.71 +4.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.2 1.247 ⚠️ +0.05
/error-in-render avg req/sec 2083.83 2004.99 ⚠️ -78.84
Client Bundles (main, webpack, commons)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.2 kB 7.2 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Hanaffi/next.js fixTemplate Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary Hanaffi/next.js fixTemplate Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary Hanaffi/next.js fixTemplate Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 2658c3a

@kodiakhq kodiakhq bot merged commit 5e255b5 into vercel:canary Apr 20, 2021
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 21, 2021
@Hanaffi @SokratisVidros
Made template look correct in IE11 (vercel#24245)
0ddb67e 
## Bug

Fixes vercel#21324

## Documentation / Examples

- [X] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Next App template does not look correct in IE11
3 participants
@Hanaffi @ijjk @leerob