Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache typechecking with incremental compilation #24559

Merged
merged 7 commits into from
May 7, 2021
Merged

cache typechecking with incremental compilation #24559

merged 7 commits into from
May 7, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 28, 2021 •
edited

  • "incremental": true is now a suggested tsconfig option and will be added automatically when typescript >= 4.3.0-beta.
  • next.js will use the a typescript api that support incremental compilation when incremental is set (also for older typescript versions)
  • This will improve build performance for larger apps

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@sokra
Copy link
Member Author

sokra commented Apr 28, 2021

@timneutkens Should we add telemetry for that? Maybe typescript version and incremental option set?

@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review April 28, 2021 19:26
@ijjk

This comment has been minimized.

Sign in to view
sokra added 2 commits May 5, 2021 11:21
@sokra
update typescript version on root to 4.3.0-beta
7f3559c
@sokra
add support for incremental typescript compilation
8520cc5 
suggest using incremental when typescript >= 4.3.0-beta
which is the version which includes the performance fixes
@sokra sokra force-pushed the feature/typescript-cache branch from 8babb64 to 8520cc5 Compare May 5, 2021 09:23
@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk reviewed May 7, 2021
View reviewed changes
yarn.lock
@@ -16146,6 +16146,11 @@ typescript@3.8.3:
version "3.8.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"

typescript@4.3.0-beta:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the other typescript versions in packages/next and packages/create-next-app to de-dupe these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should, but this leads to some new typechecking errors, so I left that for future PRs... ;)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 7, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typescript-cache Change
buildDuration 16.6s 16.7s ⚠️ +86ms
buildDurationCached 5.4s 5s -446ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +20.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js feature/typescript-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.805 2.81 0
/ avg req/sec 891.31 889.64 ⚠️ -1.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.658 1.637 -0.02
/error-in-render avg req/sec 1507.71 1527.03 +19.32
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.05 kB 3.05 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_buildManifest.js gzip 394 B 394 B ✓
Overall change 394 B 394 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/typescript-cache Change
index.html gzip 560 B 560 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typescript-cache Change
buildDuration 20.5s 20.6s ⚠️ +97ms
buildDurationCached 7.5s 7.6s ⚠️ +153ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +20.3 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.05 kB 3.05 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_buildManifest.js gzip 394 B 394 B ✓
Overall change 394 B 394 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB -2 B
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB -6 B
Overall change 6.9 MB 6.9 MB -8 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typescript-cache Change
buildDuration 13.9s 14.1s ⚠️ +156ms
buildDurationCached 6s 5.9s -45ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +20.3 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/typescript-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.855 3.045 ⚠️ +0.19
/ avg req/sec 875.56 820.93 ⚠️ -54.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.677 1.741 ⚠️ +0.06
/error-in-render avg req/sec 1490.55 1436.06 ⚠️ -54.49
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typescript-cache Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.72 kB 3.72 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typescript-cache Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/typescript-cache Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: bc92731

@timneutkens timneutkens merged commit 4e8fac9 into canary May 7, 2021
@timneutkens timneutkens deleted the feature/typescript-cache branch May 7, 2021 17:21
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@sokra @kodiakhq
cache typechecking with incremental compilation (vercel#24559)
da79e75 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens