Fix: Non-writable pages/_app breaks build #24849

darshkpatel · 2021-05-06T06:49:49Z

Added isReadable function and switched to using isReadable instead of isWriteable
Not sure if the function is placed in the correct place, let me know if I should move it somewhere else.

Also, nitpick: import {promises} from 'fs' hinders readability should I change it to something like import {promises as fsPromises} from 'fs' ?

Update:
Came across an edge case where ENAMETOOLONG wasn't handled which was causing some tests to fail.
Updated behavior to respond with status code 400 when ENAMETOOLONG is encountered.
Not entirely sure if it's the best way to handle this, let me know if I should use a different approach.

dpolugic · 2021-05-06T08:49:41Z

Also, nitpick: import {promises} from 'fs' hinders readability should I change it to something like import {promises as fsPromises} from 'fs' ?

I'm not a Next.js maintainer, but that seems like a great suggestion without any downsides. :)

packages/next/server/lib/find-page-file.ts

ijjk · 2021-05-08T04:53:30Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	12s	11.7s	-264ms
buildDurationCached	4s	3.8s	-194ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +642 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.934	1.934	✓
/ avg req/sec	1292.65	1292.97	+0.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.021	0.973	-0.05
/error-in-render avg req/sec	2447.71	2568.59	+120.88

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.3 kB	19.3 kB	✓
webpack-HASH.js gzip	996 B	996 B	✓
Overall change	59.6 kB	59.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.05 kB	3.05 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	394 B	394 B	✓
Overall change	394 B	394 B	✓

Rendered Page Sizes

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
index.html gzip	560 B	560 B	✓
link.html gzip	569 B	569 B	✓
withRouter.html gzip	557 B	557 B	✓
Overall change	1.69 kB	1.69 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	14.3s	14.7s	⚠️ +440ms
buildDurationCached	5.5s	5.6s	⚠️ +157ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +642 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.3 kB	19.3 kB	✓
webpack-HASH.js gzip	996 B	996 B	✓
Overall change	59.6 kB	59.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.05 kB	3.05 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	394 B	394 B	✓
Overall change	394 B	394 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_error.js	1.34 MB	1.34 MB	-2 B
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	1.35 MB	1.35 MB	✓
link.js	1.4 MB	1.4 MB	✓
routerDirect.js	1.39 MB	1.39 MB	✓
withRouter.js	1.39 MB	1.39 MB	✓
Overall change	6.9 MB	6.9 MB	-2 B

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	10s	9.8s	-196ms
buildDurationCached	4.2s	4.3s	⚠️ +139ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +642 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.975	2.049	⚠️ +0.07
/ avg req/sec	1265.84	1220.08	⚠️ -45.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.05	1.162	⚠️ +0.11
/error-in-render avg req/sec	2382.03	2152.01	⚠️ -230.02

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.19 kB	7.19 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.72 kB	3.72 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.37 kB	9.37 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
index.html gzip	613 B	613 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 3a63eff

ijjk · 2021-05-08T05:00:37Z

Failing test suites

Commit: 3a63eff

test/integration/file-serving/test/index.test.js

File Serving > dev mode > should prevent traversing with /%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25aftest-file.txt
File Serving > dev mode > should prevent traversing with /%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259ctest-file.txt

Expand output

● File Serving › dev mode › should prevent traversing with /%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25af%25c0%25ae%25c0%25ae%25c0%25aftest-file.txt

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  24 |   // test base mount point `public/`
  25 |   const res = await fetchViaHTTP(appPort, path)
> 26 |   expect(res.status === 400 || res.status === 404).toBe(true)
     |                                                    ^
  27 |   expect(await res.text()).toMatch(containRegex)
  28 |
  29 |   // test `/_next` mount point

  at expectStatus (integration/file-serving/test/index.test.js:26:52)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/file-serving/test/index.test.js:837:5)

● File Serving › dev mode › should prevent traversing with /%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259ctest-file.txt

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  24 |   // test base mount point `public/`
  25 |   const res = await fetchViaHTTP(appPort, path)
> 26 |   expect(res.status === 400 || res.status === 404).toBe(true)
     |                                                    ^
  27 |   expect(await res.text()).toMatch(containRegex)
  28 |
  29 |   // test `/_next` mount point

  at expectStatus (integration/file-serving/test/index.test.js:26:52)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/file-serving/test/index.test.js:1097:5)

This reverts commit 3a63eff.

darshkpatel · 2021-05-08T05:21:01Z

Found the culprit! The test fails because the response is 500 instead of 404. My mistake, Apologies.

Edit: Here's the error

[Error: ENAMETOOLONG: name too long, access '/Users/darsh/github/next.js/test/integration/file-serving/pages/%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259ctest-file.txt.tsx'] {
  errno: -63,
  code: 'ENAMETOOLONG',
  syscall: 'access',
  path: '/Users/darsh/github/next.js/test/integration/file-serving/pages/%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259c%25c0%25ae%25c0%25ae%25c1%259ctest-file.txt.tsx'
}

ijjk · 2021-05-08T09:56:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	15.3s	15.2s	-164ms
buildDurationCached	4.9s	4.7s	-183ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +172 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.659	2.668	⚠️ +0.01
/ avg req/sec	940.19	937.16	⚠️ -3.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.697	1.63	-0.07
/error-in-render avg req/sec	1472.89	1533.76	+60.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.3 kB	19.3 kB	✓
webpack-HASH.js gzip	996 B	996 B	✓
Overall change	59.6 kB	59.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.05 kB	3.05 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	394 B	394 B	✓
Overall change	394 B	394 B	✓

Rendered Page Sizes

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
index.html gzip	560 B	560 B	✓
link.html gzip	569 B	569 B	✓
withRouter.html gzip	557 B	557 B	✓
Overall change	1.69 kB	1.69 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	18.6s	18.9s	⚠️ +220ms
buildDurationCached	6.9s	6.8s	-70ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +172 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.3 kB	19.3 kB	✓
webpack-HASH.js gzip	996 B	996 B	✓
Overall change	59.6 kB	59.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.05 kB	3.05 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	8.52 kB	8.52 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	394 B	394 B	✓
Overall change	394 B	394 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_error.js	1.34 MB	1.34 MB	⚠️ +27 B
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	1.35 MB	1.35 MB	⚠️ +27 B
link.js	1.4 MB	1.4 MB	⚠️ +27 B
routerDirect.js	1.39 MB	1.39 MB	⚠️ +29 B
withRouter.js	1.39 MB	1.39 MB	⚠️ +27 B
Overall change	6.9 MB	6.9 MB	⚠️ +137 B

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
buildDuration	12.9s	12.5s	-428ms
buildDurationCached	5.3s	5.3s	-11ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +172 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.662	2.639	-0.02
/ avg req/sec	939.19	947.21	+8.02
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.714	1.655	-0.06
/error-in-render avg req/sec	1458.31	1510.35	+52.04

Client Bundles (main, webpack, commons)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.19 kB	7.19 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.72 kB	3.72 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.37 kB	9.37 kB	✓

Client Build Manifests

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	darshkpatel/next.js fix/24772	Change
index.html gzip	613 B	613 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 5a6c847

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

use isReadable instead of isWriteable

20ea370

darshkpatel requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners May 6, 2021 06:49

ijjk added the type: next label May 6, 2021

This comment has been minimized.

Sign in to view

timneutkens reviewed May 6, 2021

View reviewed changes

packages/next/server/lib/find-page-file.ts Outdated Show resolved Hide resolved

darshkpatel added 3 commits May 6, 2021 16:06

switch to fileExists

a07307b

Merge branch 'canary' into fix/24772

9cd3188

shorten import

e795cd7

This comment has been minimized.

Sign in to view

timneutkens previously approved these changes May 6, 2021

View reviewed changes

retrigger checks

d928b2c

This comment has been minimized.

Sign in to view

Merge branch 'canary' into fix/24772

c00363b

This comment has been minimized.

Sign in to view

Merge branch 'canary' into fix/24772

83a9620

This comment has been minimized.

Sign in to view

fallback to isReadable

3a63eff

darshkpatel dismissed timneutkens’s stale review via 3a63eff May 8, 2021 04:43

darshkpatel requested a review from timneutkens May 8, 2021 04:44

Revert "fallback to isReadable"

a8b03a7

This reverts commit 3a63eff.

darshkpatel added 2 commits May 8, 2021 14:44

Handle ENAMETOOLONG error

e9c4099

Merge branch 'canary' into fix/24772

5a6c847

timneutkens approved these changes May 10, 2021

View reviewed changes

Merge branch 'canary' into fix/24772

9dd3e10

timneutkens merged commit 9e87596 into vercel:canary May 10, 2021

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021

Fix: Non-writable pages/_app breaks build (vercel#24849)

b09532f

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Non-writable pages/_app breaks build #24849

Fix: Non-writable pages/_app breaks build #24849

darshkpatel commented May 6, 2021 •

edited

This comment has been minimized.

dpolugic commented May 6, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented May 8, 2021

ijjk commented May 8, 2021

darshkpatel commented May 8, 2021 •

edited

ijjk commented May 8, 2021

Fix: Non-writable pages/_app breaks build #24849

Fix: Non-writable pages/_app breaks build #24849

Conversation

darshkpatel commented May 6, 2021 • edited

This comment has been minimized.

dpolugic commented May 6, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented May 8, 2021

Stats from current PR

ijjk commented May 8, 2021

Failing test suites

darshkpatel commented May 8, 2021 • edited

ijjk commented May 8, 2021

Stats from current PR

darshkpatel commented May 6, 2021 •

edited

darshkpatel commented May 8, 2021 •

edited