Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: More updates and bug fixes #25952

Merged
merged 2 commits into from Jun 10, 2021
Merged

ESLint: More updates and bug fixes #25952

merged 2 commits into from Jun 10, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@ijjk
Copy link
Member

ijjk commented Jun 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
buildDuration 10.7s 10.8s ⚠️ +141ms
buildDurationCached 2.7s 2.6s -120ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +9.61 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
/ failed reqs 0 0
/ total time (seconds) 2.121 2.168 ⚠️ +0.05
/ avg req/sec 1178.95 1153.24 ⚠️ -25.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.094 1.103 ⚠️ +0.01
/error-in-render avg req/sec 2284.66 2265.54 ⚠️ -19.12
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
index.html gzip 573 B 573 B
link.html gzip 581 B 581 B
withRouter.html gzip 568 B 568 B
Overall change 1.72 kB 1.72 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
buildDuration 12.2s 12.2s -53ms
buildDurationCached 3.6s 3.6s -4ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +9.61 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_error.js 16.9 kB 16.9 kB
404.html 2.44 kB 2.44 kB
500.html 2.43 kB 2.43 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.63 kB 1.63 kB
css.html 1.81 kB 1.81 kB
hooks.html 1.69 kB 1.69 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB ⚠️ +2 B
Overall change 107 kB 107 kB ⚠️ +2 B

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
buildDuration 9.4s 9.6s ⚠️ +223ms
buildDurationCached 3.9s 3.9s ⚠️ +4ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +9.61 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
/ failed reqs 0 0
/ total time (seconds) 2.183 2.146 -0.04
/ avg req/sec 1145.18 1165.06 +19.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.099 1.092 -0.01
/error-in-render avg req/sec 2274.99 2290.04 +15.05
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 61.1 kB 61.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.17 kB 9.17 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint-update-3 Change
index.html gzip 627 B 627 B
link.html gzip 633 B 633 B
withRouter.html gzip 620 B 620 B
Overall change 1.88 kB 1.88 kB
Commit: 2d49baa

@timneutkens timneutkens merged commit 436e74b into vercel:canary Jun 10, 2021
janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants