Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NextPage type to create-next-app typescript template #27246

Merged
merged 3 commits into from Jul 16, 2021

Conversation

Ryz0nd
Copy link
Contributor

@Ryz0nd Ryz0nd commented Jul 16, 2021

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 16, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
buildDuration 15.5s 15.9s ⚠️ +350ms
buildDurationCached 3.6s 3.6s -25ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
/ failed reqs 0 0
/ total time (seconds) 2.49 2.471 -0.02
/ avg req/sec 1003.86 1011.82 +7.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.376 1.32 -0.06
/error-in-render avg req/sec 1817.25 1894.44 +77.19
Client Bundles (main, webpack, commons)
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.6 kB 5.6 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
buildDuration 12.6s 12.4s -185ms
buildDurationCached 4.8s 4.8s -2ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
/ failed reqs 0 0
/ total time (seconds) 2.487 2.489 0
/ avg req/sec 1005.17 1004.54 ⚠️ -0.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.31 1.411 ⚠️ +0.1
/error-in-render avg req/sec 1907.67 1772.34 ⚠️ -135.33
Client Bundles (main, webpack, commons)
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.4 kB 68.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary Ryz0nd/next.js create-next-app-page-type Change
index.html gzip 577 B 577 B
link.html gzip 588 B 588 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 8a81342

@kodiakhq kodiakhq bot merged commit 736db42 into vercel:canary Jul 16, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants