Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default server host value causing issues on Windows #27306

Merged
merged 4 commits into from Jul 19, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 19, 2021

This fixes a case where the HMR connection for fast refresh would fail to connect on Windows due to a change being made to the default host being listened to. Previously we didn't set a default for the host value when calling server.listen which allowed the default listening behavior to be used although in #20409 a default of 0.0.0.0 was added which causes conflicts for some set-ups mainly on Windows it seems.

Bug

  • Related issues linked using fixes #number
  • Integration tests added (N/A)
  • Errors have helpful link attached, see contributing.md

Fixes: #27298
Fixes: #27254
Fixes: #4456 (comment)
Fixes: #20409 (comment)
x-ref: #20409

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this to ensure it fixes the bug?

@ijjk

This comment has been minimized.

Co-authored-by: Steven <steven@ceriously.com>
@ijjk
Copy link
Member Author

ijjk commented Jul 19, 2021

It doesn't look like we can add a test case for this since it affects specific Windows configurations/network setups, although an affected user helped confirm this resolved the issue here #27298 (comment)

@ijjk ijjk requested a review from styfle July 19, 2021 21:19
styfle
styfle previously approved these changes Jul 19, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Jul 19, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/windows-listening Change
buildDuration 13s 12.9s -97ms
buildDurationCached 3s 3s -34ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +349 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/windows-listening Change
/ failed reqs 0 0
/ total time (seconds) 2.079 2.057 -0.02
/ avg req/sec 1202.39 1215.48 +13.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.114 1.13 ⚠️ +0.02
/error-in-render avg req/sec 2244.41 2211.66 ⚠️ -32.75
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/windows-listening Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/windows-listening Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/windows-listening Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.6 kB 5.6 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/windows-listening Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/windows-listening Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/windows-listening Change
buildDuration 10.5s 10.4s -92ms
buildDurationCached 4.1s 4s -78ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +349 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/windows-listening Change
/ failed reqs 0 0
/ total time (seconds) 2.07 2.044 -0.03
/ avg req/sec 1207.75 1223.33 +15.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.1 1.113 ⚠️ +0.01
/error-in-render avg req/sec 2272.58 2246.22 ⚠️ -26.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/windows-listening Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.4 kB 68.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/windows-listening Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/windows-listening Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/windows-listening Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/windows-listening Change
index.html gzip 577 B 577 B
link.html gzip 588 B 588 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 0edc2e5

@kodiakhq kodiakhq bot merged commit 1effbae into vercel:canary Jul 19, 2021
@ijjk ijjk deleted the fix/windows-listening branch July 19, 2021 23:14
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
This fixes a case where the HMR connection for fast refresh would fail to connect on Windows due to a change being made to the default host being listened to. Previously we didn't set a default for the `host` value when calling `server.listen` which allowed the default listening behavior to be used although in vercel#20409 a default of `0.0.0.0` was added which causes conflicts for some set-ups mainlly on Windows it seems. 

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added (N/A)
- [x] Errors have helpful link attached, see `contributing.md`

Fixes: vercel#27298
Fixes: vercel#27254
Fixes: vercel#4456 (comment)
Fixes: vercel#20409 (comment)
x-ref: vercel#20409
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants