Update cms agilitycms #27378
Update cms agilitycms #27378
Conversation
joshua-isaac
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
| <Link href={`/blog/${featuredPost.fields.slug}`}> | ||
| <a className="cursor-pointer"> | ||
| <div className="h-64 sm:h-96 relative"> | ||
| <AgilityImage |
There was a problem hiding this comment.
Any insight why Agility image over next/image?
There was a problem hiding this comment.
@leerob AgilityImage actually uses next/image behind the scenes! It avoids the need for any other config as it just changes the image URL parameters to resize it or change format and quality on our CDN
| return dynamicUrls; | ||
| }; | ||
|
|
||
| PostsListing.getCustomInitialProps = async ({ |
There was a problem hiding this comment.
@leerob getCustomInitialProps fetches additional data from Agility during the build process
|
|
||
| export default async (req, res) => { | ||
|
|
||
| //TODO: Only generate the preview link if you are already in Preview! |
There was a problem hiding this comment.
created an issue so we have this todo tracked: agility/agilitycms-nextjs-starter#24
|
|
||
| let previewUrl = req.query.slug; | ||
|
|
||
| //TODO: these kinds of dynamic links should work by default (even outside of preview) |
There was a problem hiding this comment.
created an issue so we have this todo tracked: agility/agilitycms-nextjs-starter#25
| lineHeight: { | ||
| tight: 1.2, | ||
| teal: { | ||
| 100: "#e6fffa", |
There was a problem hiding this comment.
Should this just use the default color palette from Tailwind?
There was a problem hiding this comment.
I guess I could just extend the default tailwind color palette instead of creating a new one, thanks!
|
@joshua-isaac this PR has some merge conflicts and given it has been opened for a while, I'm closing it. If you would like to address the conflicts, feel free to reopen, otherwise, someone else might want to take a look! Thanks! 🙏 💚 |
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples