Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade styled-jsx #27782

Merged
merged 3 commits into from Aug 5, 2021
Merged

Upgrade styled-jsx #27782

merged 3 commits into from Aug 5, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 5, 2021

  • Update styed-jsx to latest version, containing bugfixes for babel plugin and typings.
  • Use /// <reference> instead of redeclaring types

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 5, 2021
@ijjk
Copy link
Member

ijjk commented Aug 5, 2021

Failing test suites

Commit: da39275

test/acceptance/ReactRefreshRequire.dev.test.js

  • re-runs accepted modules

  • propagates a hot update to closest accepted module

Expand output

● re-runs accepted modules

expect(received).toEqual(expected) // deep equality

Expected: ["init FooV1", "init BarV1"]
Received: null

  27 |     `require('./foo'); export default function Noop() { return null; };`
  28 |   )
> 29 |   expect(await session.evaluate(() => window.log)).toEqual([
     |                                                    ^
  30 |     'init FooV1',
  31 |     'init BarV1',
  32 |   ])

  at Object.<anonymous> (acceptance/ReactRefreshRequire.dev.test.js:29:52)

● propagates a hot update to closest accepted module

expect(received).toEqual(expected) // deep equality

Expected: ["init FooV1", "init BarV1"]
Received: null

  85 |   )
  86 |
> 87 |   expect(await session.evaluate(() => window.log)).toEqual([
     |                                                    ^
  88 |     'init FooV1',
  89 |     'init BarV1',
  90 |   ])

  at Object.<anonymous> (acceptance/ReactRefreshRequire.dev.test.js:87:52)

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 5, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
buildDuration 17.2s 17.6s ⚠️ +363ms
buildDurationCached 3.9s 4.1s ⚠️ +216ms
nodeModulesSize 50.2 MB 50.2 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.093 2.991 -0.1
/ avg req/sec 808.37 835.97 +27.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.033 1.998 -0.03
/error-in-render avg req/sec 1229.43 1251.32 +21.89
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
index.html gzip 531 B 531 B
link.html gzip 542 B 542 B
withRouter.html gzip 523 B 523 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
buildDuration 14.2s 13.6s -525ms
buildDurationCached 5.4s 5.4s ⚠️ +28ms
nodeModulesSize 50.2 MB 50.2 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.039 3.153 ⚠️ +0.11
/ avg req/sec 822.72 792.98 ⚠️ -29.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.946 1.899 -0.05
/error-in-render avg req/sec 1284.78 1316.81 +32.03
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-styled-jsx Change
index.html gzip 576 B 576 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 04f9294

@huozhi huozhi marked this pull request as ready for review August 5, 2021 17:05
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit 567d47b into vercel:canary Aug 5, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
* Update styed-jsx to latest version, containing bugfixes for babel plugin and typings.
* Use `/// <reference>` instead of redeclaring types


## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
@huozhi huozhi deleted the upgrade-styled-jsx branch August 30, 2021 14:43
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants