Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint plugin install instructions in docs #27807

Merged
merged 3 commits into from Aug 6, 2021

Conversation

stefanprobst
Copy link
Contributor

this pr fixes the install instructions in the docs for the Next.js ESLint plugin.


sidenote: there are a few other places where the plugin is called eslint-plugin-next, but links to the correct @next/eslint-plugin-next, e.g.:

- [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next)

not sure if intentional, or is the goal to eventually publish the plugin as eslint-plugin-next (which is owned by timer but currently empty)?


Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Copy link
Collaborator

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for this! The initial plan was to publish to eslint-plugin-next, but since that hasn't happened the docs shouldn't be incorrect. If we end up publishing to eslint-plugin-next, we can update accordingly :).

@ijjk ijjk merged commit 62707d4 into vercel:canary Aug 6, 2021
@stefanprobst stefanprobst deleted the docs/eslint-plugin-install branch August 6, 2021 17:04
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants