Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper error when failing to load next.config.js #28099

Merged
merged 3 commits into from Aug 14, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 14, 2021

This adds a proper error when we fail to load a user's next.config.js as the default node error can be confusing on its own and makes it seem like something failed internally in Next.js. We can expand on the included error doc added and potentially also add better syntax errors by parsing with acorn when we fail to load this file in the future.

screenshot Screen Shot 2021-08-13 at 21 46 09

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Aug 14, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2021

Failing test suites

Commit: b838c7c

test/acceptance/ReactRefreshLogBox.dev.test.js

  • server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=92.0.4515.131)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1422:3)

@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/config-load-error Change
buildDuration 11.5s 11.4s -100ms
buildDurationCached 2.9s 2.9s -48ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +677 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/config-load-error Change
/ failed reqs 0 0
/ total time (seconds) 2.251 2.249 0
/ avg req/sec 1110.77 1111.41 +0.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.271 1.248 -0.02
/error-in-render avg req/sec 1967.05 2003.84 +36.79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/config-load-error Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/config-load-error Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/config-load-error Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/config-load-error Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/config-load-error Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/config-load-error Change
buildDuration 9.4s 9.3s -56ms
buildDurationCached 3.9s 3.8s -69ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +677 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/config-load-error Change
/ failed reqs 0 0
/ total time (seconds) 2.255 2.293 ⚠️ +0.04
/ avg req/sec 1108.52 1090.27 ⚠️ -18.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.27 1.288 ⚠️ +0.02
/error-in-render avg req/sec 1969.15 1940.71 ⚠️ -28.44
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/config-load-error Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/config-load-error Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/config-load-error Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/config-load-error Change
_buildManifest.js gzip 497 B 497 B
Overall change 497 B 497 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/config-load-error Change
index.html gzip 585 B 585 B
link.html gzip 598 B 598 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: bdf9983

@kodiakhq kodiakhq bot merged commit 0397353 into vercel:canary Aug 14, 2021
31 checks passed
@ijjk ijjk deleted the add/config-load-error branch Aug 14, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants