Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let loaders automatically infer source map setting #28204

Merged
merged 2 commits into from Aug 17, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 17, 2021

These loaders automatically use the global source map setting when this option is omitted

styfle
styfle approved these changes Aug 17, 2021
ijjk
ijjk approved these changes Aug 17, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 17, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js perf/infer-source-map Change
buildDuration 12.8s 12.8s -39ms
buildDurationCached 3.2s 3s -169ms
nodeModulesSize 61.5 MB 61.5 MB -294 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js perf/infer-source-map Change
/ failed reqs 0 0
/ total time (seconds) 2.243 2.264 ⚠️ +0.02
/ avg req/sec 1114.48 1104.42 ⚠️ -10.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.332 1.209 -0.12
/error-in-render avg req/sec 1876.67 2067.27 +190.6
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/infer-source-map Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/infer-source-map Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js perf/infer-source-map Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.65 kB 2.65 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js perf/infer-source-map Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/infer-source-map Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js perf/infer-source-map Change
buildDuration 10.9s 10.8s -129ms
buildDurationCached 4.5s 4.4s -103ms
nodeModulesSize 61.5 MB 61.5 MB -294 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js perf/infer-source-map Change
/ failed reqs 0 0
/ total time (seconds) 2.291 2.215 -0.08
/ avg req/sec 1091.09 1128.76 +37.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.343 1.321 -0.02
/error-in-render avg req/sec 1862.05 1892.47 +30.42
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/infer-source-map Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/infer-source-map Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js perf/infer-source-map Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.85 kB 2.85 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/infer-source-map Change
_buildManifest.js gzip 499 B 500 B ⚠️ +1 B
Overall change 499 B 500 B ⚠️ +1 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/infer-source-map Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for _buildManifest.js
@@ -6,8 +6,8 @@ self.__BUILD_MANIFEST = {
   ],
   "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-4855291bfb1c5a551232.js"],
   "/css": [
-    "static\u002Fcss\u002Fe025d27648136bbd252f.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-d324ec3ec9abb3848ae8.js"
+    "static\u002Fcss\u002F30809af5c834595ef565.css",
+    "static\u002Fchunks\u002Fpages\u002Fcss-c95c4860f8f0d43ed2d2.js"
   ],
   "/dynamic": [
     "static\u002Fchunks\u002Fpages\u002Fdynamic-3b3842923577b772252c.js"
Commit: 7015192

@kodiakhq kodiakhq bot merged commit b594f5b into canary Aug 17, 2021
32 checks passed
@kodiakhq kodiakhq bot deleted the perf/infer-source-map branch Aug 17, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants