Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zen-observable library #28214

Merged
merged 15 commits into from Aug 18, 2021
Merged

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Aug 17, 2021

Our Observable use has gotten sufficiently complex that it makes sense to just use a 3rd party implementation and not worry about maintaining it ourselves. As a bonus, it doesn't rely on Node APIs.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Aug 17, 2021
@ijjk

This comment has been minimized.

@devknoll devknoll marked this pull request as ready for review Aug 17, 2021
@ijjk

This comment has been minimized.

packages/next/server/utils.ts Outdated Show resolved Hide resolved
packages/next/server/next-server.ts Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 18, 2021

Failing test suites

Commit: 6f06bb1

test/integration/route-load-cancel/test/index.test.js

  • next/dynamic > dev mode > should cancel slow page loads on re-navigation
Expand output

● next/dynamic › dev mode › should cancel slow page loads on re-navigation

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#page-text"}
  (Session info: headless chrome=92.0.4515.131)

  31 |     await waitFor(1000)
  32 |
> 33 |     const text = await browser.elementByCss('#page-text').text()
     |                  ^
  34 |     expect(text).toMatch(/2/)
  35 |     expect(await browser.eval('window.routeCancelled')).toBe('yes')
  36 |   })

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/route-load-cancel/test/index.test.js:33:18)

@ijjk
Copy link
Member

ijjk commented Aug 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
buildDuration 16.3s 16.3s -49ms
buildDurationCached 4.1s 3.9s -127ms
nodeModulesSize 61.5 MB 61.5 MB ⚠️ +2.32 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
/ failed reqs 0 0
/ total time (seconds) 3.039 3.075 ⚠️ +0.04
/ avg req/sec 822.72 812.89 ⚠️ -9.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.886 1.914 ⚠️ +0.03
/error-in-render avg req/sec 1325.27 1305.92 ⚠️ -19.35
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
buildDuration 13.6s 13.6s -13ms
buildDurationCached 5.5s 5.8s ⚠️ +329ms
nodeModulesSize 61.5 MB 61.5 MB ⚠️ +2.32 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
/ failed reqs 0 0
/ total time (seconds) 3.05 3.119 ⚠️ +0.07
/ avg req/sec 819.65 801.54 ⚠️ -18.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.828 1.903 ⚠️ +0.07
/error-in-render avg req/sec 1367.45 1313.58 ⚠️ -53.87
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-zen-observable Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 7274335

ijjk
ijjk approved these changes Aug 18, 2021
@kodiakhq kodiakhq bot merged commit 51559f5 into vercel:canary Aug 18, 2021
32 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants