Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forked NODE_OPTIONS except for inspect #28420

Merged
merged 2 commits into from Aug 23, 2021
Merged

Conversation

vcnc-hex
Copy link
Contributor

@vcnc-hex vcnc-hex commented Aug 23, 2021

Bug

fixes #27000

In Yarn PnP Strict Mode, preloaded modules from NODE_OPTIONS=--require=.pnp.js should be forwared to the workers.
To make it work, NODE_OPTIONS inside of forkerOptions must include preload scripts --require=.pnp.js and without inspect options.

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

styfle
styfle approved these changes Aug 23, 2021
Copy link
Member

@styfle styfle left a comment

Looks like NODE_OPTIONS was changed in #25876 and that test is passing, thanks! 👍

ijjk
ijjk approved these changes Aug 23, 2021
@ijjk
Copy link
Member

ijjk commented Aug 23, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vcnc-hex/next.js canary Change
buildDuration 12.9s 12.8s -50ms
buildDurationCached 3s 2.9s -59ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +240 B
Page Load Tests Overall increase ✓
vercel/next.js canary vcnc-hex/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.253 2.259 ⚠️ +0.01
/ avg req/sec 1109.54 1106.86 ⚠️ -2.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.263 1.247 -0.02
/error-in-render avg req/sec 1979.81 2004.8 +24.99
Client Bundles (main, webpack, commons)
vercel/next.js canary vcnc-hex/next.js canary Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vcnc-hex/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vcnc-hex/next.js canary Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vcnc-hex/next.js canary Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary vcnc-hex/next.js canary Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary vcnc-hex/next.js canary Change
buildDuration 10.5s 10.6s ⚠️ +96ms
buildDurationCached 4.6s 4.5s -23ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +240 B
Page Load Tests Overall increase ✓
vercel/next.js canary vcnc-hex/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.374 2.346 -0.03
/ avg req/sec 1053.17 1065.76 +12.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.295 1.3 ⚠️ +0.01
/error-in-render avg req/sec 1930.75 1923 ⚠️ -7.75
Client Bundles (main, webpack, commons)
vercel/next.js canary vcnc-hex/next.js canary Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vcnc-hex/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vcnc-hex/next.js canary Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3 kB 3 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary vcnc-hex/next.js canary Change
_buildManifest.js gzip 501 B 501 B
Overall change 501 B 501 B
Rendered Page Sizes
vercel/next.js canary vcnc-hex/next.js canary Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: cf263a1

@ijjk ijjk merged commit 00f1519 into vercel:canary Aug 23, 2021
26 of 32 checks passed
@styfle
Copy link
Member

styfle commented Aug 24, 2021

This has been released in v11.1.1-canary.14

Try it out now with yarn add next@canary, thanks!

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-worker breaks building the project with "write EPIPE" error on macOS
3 participants