Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure traces are flushed in development when there is an error #29149

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Ensure traces are flushed in development when there is an error #29149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/next/build/output/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,15 @@ store.subscribe((state) => {
}
}

// Ensure traces are flushed after each compile in development mode
flushAllTraces()
return
}

if (state.warnings) {
Log.warn(state.warnings.join('\n\n'))
if (state.appUrl) {
Log.info(`ready on ${state.appUrl}`)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an accidental leftover that I just noticed so I've removed it 👍

}
// Ensure traces are flushed after each compile in development mode
flushAllTraces()
return
}

Expand Down